-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Easily available custom package server #12
Conversation
Just outline it in Markdown so I have a target to code against when recreating it.
It's not just the Elm package server API details anymore
Extremely bare bones at the moment
This lets us store files directly in the sqlite database with some nice extra support
This reverts commit 1a06dbe.
There's still some bug now where I can't pull down all-packages for some HTTPS reason
One final issue which is the problem of actually calculating file hashes for the package server instead of just always writing "some-hash"
5da7149
to
7a0d8b8
Compare
This was part of an unfinished commit that shouldn't have been committed
Now you can view packages!
This is what will be shared with the community!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is cool – but yeah a lot to review 😅
Some drive-by thoughts:
- SQLite as an embedded and portable DB could be worth considering rather than hand rolling another on-disk format (your design notes were incomplete so unsure if you did further exploration of this)
- You might consider extracting more of the modifications to the core Elm files if you haven't already, to keep future potential diffs against upstream cleaner. They don't look particularly large, and obviously diminishing returns when added functions need to use local types, but I notice you're mixing in imports and functions – having a clear
-- @zokka
marker where additions are clearly appended to the ends of the imports / file may help maintenance (and clarity on what's zokka divergence and what's not) in future.
I've not had a chance to try this out yet, but hope to check it out this weekend 👍
Co-authored-by: Mario Rogic <[email protected]>
Yep @supermario you're right on the money! I decided to go with SQLite instead. I agree with you that I should move out all the Zokka stuff to make it more clear what is new in Zokka and what is in Elm. I'll likely do that as a separate PR to combine with the pre-existing Zokka additions I have. |
This is because otherwise we'll mess with the enable executable static flag
Quick Summary:
Creating a new custom package repository server that decouples us from GitHub and git and serves as the basis for a separate online service that can offer one-click custom package repositories. See
CUSTOM_PACKAGE_SERVER_REFERENCE_NOTES.md
for more details.