remove .Online from notifiers and toggle service.Online when needed. f…

…ixes statping#118

core/checker.go

@@ -243,7 +243,6 @@ func (s *Service) checkHttp(record bool) *Service {
 		}
 		return s
 	}
-	s.Online = true
 	if record {
 		recordSuccess(s)
 	}
@@ -252,7 +251,6 @@ func (s *Service) checkHttp(record bool) *Service {
 
 // recordSuccess will create a new 'hit' record in the database for a successful/online service
 func recordSuccess(s *Service) {
-	s.Online = true
 	s.LastOnline = utils.Timezoner(time.Now().UTC(), CoreApp.Timezone)
 	hit := &types.Hit{
 		Service:   s.Id,
@@ -263,11 +261,11 @@ func recordSuccess(s *Service) {
 	utils.Log(1, fmt.Sprintf("Service %v Successful Response: %0.2f ms | Lookup in: %0.2f ms", s.Name, hit.Latency*1000, hit.PingTime*1000))
 	s.CreateHit(hit)
 	notifier.OnSuccess(s.Service)
+	s.Online = true
 }
 
 // recordFailure will create a new 'Failure' record in the database for a offline service
 func recordFailure(s *Service, issue string) {
-	s.Online = false
 	fail := &Failure{&types.Failure{
 		Service:   s.Id,
 		Issue:     issue,
@@ -278,4 +276,6 @@ func recordFailure(s *Service, issue string) {
 	utils.Log(2, fmt.Sprintf("Service %v Failing: %v | Lookup in: %0.2f ms", s.Name, issue, fail.PingTime*1000))
 	s.CreateFailure(fail)
 	notifier.OnFailure(s.Service, fail.Failure)
+	s.Online = false
+
 }

core/notifier/events.go

@@ -39,6 +39,7 @@ func OnFailure(s *types.Service, f *types.Failure) {
 			comm.(BasicEvents).OnFailure(s, f)
 		}
 	}
+
 }
 
 // OnSuccess will be triggered when a service is successful - BasicEvents interface
@@ -51,6 +52,7 @@ func OnSuccess(s *types.Service) {
 			comm.(BasicEvents).OnSuccess(s)
 		}
 	}
+
 }
 
 // OnNewService is triggered when a new service is created - ServiceEvents interface

core/notifier/notifiers.go

@@ -62,7 +62,6 @@ type Notification struct {
 	Delay       time.Duration      `gorm:"-" json:"delay,string"`
 	Queue       []*QueueData       `gorm:"-" json:"-"`
 	Running     chan bool          `gorm:"-" json:"-"`
-	Online      bool               `gorm:"-" json:"online"`
 	testable    bool               `gorm:"-" json:"testable"`
 }