[Reflection] Loads mixed-mode assemblies containing fixups from file …

…instead of from byte array (fixes issue stride3d#1066)
ZyndaDeng · Jun 24, 2021 · 68ecc62 · 68ecc62
1 parent fe6a604
commit 68ecc62
Showing 1 changed file with 11 additions and 1 deletion.
diff --git a/sources/core/Stride.Core.Design/Reflection/AssemblyContainer.cs b/sources/core/Stride.Core.Design/Reflection/AssemblyContainer.cs
@@ -300,7 +300,17 @@ private Assembly LoadAssemblyFromPathInternal([NotNull] string assemblyFullPath)
                         }
 
                         // TODO: Is using AppDomain would provide more opportunities for unloading?
-                        assembly = pdbBytes != null ? Assembly.Load(assemblyBytes, pdbBytes) : Assembly.Load(assemblyBytes);
+                        const uint unverifiableExecutableWithFixups = 0x80131019;
+                        try
+                        {
+                            assembly = pdbBytes != null ? Assembly.Load(assemblyBytes, pdbBytes) : Assembly.Load(assemblyBytes);
+                        }
+                        catch (FileLoadException fileLoadException)
+                        when ((uint)fileLoadException.HResult == unverifiableExecutableWithFixups)
+                        {
+                            // No way to load from byte array (see https://stackoverflow.com/questions/5005409/exception-with-resolving-assemblies-attempt-to-load-an-unverifiable-executable)
+                            assembly = Assembly.LoadFrom(assemblyFullPath);
+                        }
                         loadedAssembly = new LoadedAssembly(this, assemblyFullPath, assembly, dependenciesMapping);
                         loadedAssemblies.Add(loadedAssembly);
                         loadedAssembliesByName.Add(assemblyFullPath, loadedAssembly);