Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable a few skipped tests for s390x & ppc64le. #111

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Enable a few skipped tests for s390x & ppc64le. #111

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1754e6e
Enable a few skipped tests for s390x & ppc64le.
jsirois Dec 20, 2024
09813a6
Fix installer arg test to include s390x / ppc64le support.
jsirois Dec 20, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 1 addition & 10 deletions tests/test_installer.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,6 @@
from _pytest.tmpdir import TempPathFactory

from science.os import IS_WINDOWS
from science.platform import Platform


@pytest.fixture(scope="module")
Expand All @@ -31,13 +30,6 @@ def test_installer_help(installer: list):
assert long_help in result.stdout, f"Expected '{long_help}' in tool output"


skip_ppc64le_and_s390x = pytest.mark.skipif(
Platform.current() in (Platform.Linux_powerpc64le, Platform.Linux_s390x),
reason="Requires a release after 0.9.0 containing ppc64le and s390x support.",
)


@skip_ppc64le_and_s390x
def test_installer_fetch_latest(tmp_path_factory: TempPathFactory, installer: list):
"""Invokes install.sh to fetch the latest science release binary, then invokes it."""
test_dir = tmp_path_factory.mktemp("install-test-default")
Expand All @@ -52,11 +44,10 @@ def test_installer_fetch_latest(tmp_path_factory: TempPathFactory, installer: li
assert result.stdout.strip(), "Expected version output in tool stdout"


@skip_ppc64le_and_s390x
def test_installer_fetch_argtest(tmp_path_factory: TempPathFactory, installer: list):
"""Exercises all the options in the installer."""
test_dir = tmp_path_factory.mktemp("install-test")
test_ver = "0.9.0"
test_ver = "0.10.0"
bin_dir = test_dir / "bin"

assert (result := run_captured(installer + ["-V", test_ver, "-d", bin_dir])).returncode == 0
Expand Down