fix: protocolHeaders can split with whitespace (eggjs#164)

a382695908 · Dec 19, 2016 · db614d4 · db614d4
1 parent 3b43ed1
commit db614d4
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/app/extend/request.js b/app/extend/request.js
@@ -56,7 +56,7 @@ module.exports = {
     }
 
     if (typeof this.app.config.protocolHeaders === 'string' && this.app.config.protocolHeaders) {
-      const protocolHeaders = this.app.config.protocolHeaders.split(',');
+      const protocolHeaders = this.app.config.protocolHeaders.split(/\s*,\s*/);
       for (const header of protocolHeaders) {
         let proto = this.get(header);
         if (proto) {

diff --git a/test/app/extend/request.test.js b/test/app/extend/request.test.js
@@ -90,7 +90,7 @@ describe('test/app/extend/request.test.js', () => {
       });
 
       it('should return value of X-Custom-Proto', () => {
-        mm(app.config, 'protocolHeaders', 'X-Custom-Proto');
+        mm(app.config, 'protocolHeaders', 'X-Forwarded-Proto, X-Custom-Proto');
         return request(app.callback())
           .get('/protocol')
           .set('X-Custom-Proto', 'https')