Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nlohmann optional #1

Merged
merged 77 commits into from
Oct 21, 2023
Merged
Changes from 1 commit
Commits
Show all changes
77 commits
Select commit Hold shift + click to select a range
bf69331
feat: add always-allow-substitutes
lovesegfault Mar 14, 2023
3ae1489
nix flakes metadata: Show lastModified timestamp for each input
wfranzini Jan 31, 2023
f7b8f8a
Introduce separate Serve protocol serialisers
Ericson2314 May 26, 2023
b4b1a07
store info alias created
vicky1999 Oct 13, 2023
5c65379
info store alias added to store-ping
vicky1999 Oct 13, 2023
db0d945
Document builtins.fetchTree
wentasah Jun 11, 2023
856fe13
fetchTree cleanup
edolstra Sep 28, 2023
4ce7a53
Update fetchTree docs
edolstra Sep 28, 2023
8eb4f73
fetchTree: Only use the registry if flakes are enabled
edolstra Sep 29, 2023
2084312
Merge pull request #9061 from edolstra/stabilize-fetchTree
edolstra Oct 13, 2023
da2b59a
Merge pull request #8047 from lovesegfault/always-allow-substitutes
roberth Oct 13, 2023
4112dd1
Mark fetchTree as stable
edolstra Sep 25, 2023
d070d8b
Merge pull request #9137 from obsidiansystems/serve-protocol
Ericson2314 Oct 13, 2023
a23cc14
Factor out Perl bindings Nix package
Ericson2314 Oct 13, 2023
e5ce53f
explicitly set meta.mainProgram
eclairevoyant Oct 15, 2023
6bf68c1
Merge pull request #8904 from wentasah/metadata-shows-last-modified
edolstra Oct 16, 2023
d12c614
Merge pull request #9152 from obsidiansystems/split-out-perl-nix
Ericson2314 Oct 16, 2023
c27d2f8
Add two more completions tests
Ericson2314 Apr 3, 2023
483d99c
Add API docs to some args-related functionality
Ericson2314 Oct 16, 2023
5442d9b
Merge pull request #9167 from obsidiansystems/pre-overhaul-completions
Ericson2314 Oct 16, 2023
f7a36f9
Fix language tests a bit
Ericson2314 Oct 16, 2023
b3fd7db
Detect cycles in flake follows.
vkryachko Oct 16, 2023
add066c
Fix broken move
tfc Oct 16, 2023
aa4f41d
Merge pull request #9170 from tfc/fix-broken-move
Ericson2314 Oct 16, 2023
d6066c9
Don't convert InputPaths to strings prematurely.
vkryachko Oct 16, 2023
abf7df2
Fix moves that accidentally copy anyway
tfc Oct 16, 2023
54b350d
Drop some moves that would happen anyway but forbid NRVO where appicable
tfc Oct 16, 2023
8c049a9
Merge pull request #9172 from tfc/bad-moves
Ericson2314 Oct 16, 2023
dcc5f80
Store info command help updates
vicky1999 Oct 17, 2023
a9b8595
Merge pull request #9162 from eclairevoyant/add-mainprogram
edolstra Oct 17, 2023
e92cac7
Merge pull request #9168 from obsidiansystems/fix-lang-tests-read-only
edolstra Oct 17, 2023
f62b550
fetchTree: Require the flakes experimental feature for the URL syntax
edolstra Oct 17, 2023
3470cd6
Mark some fetchers as experimental
edolstra Oct 17, 2023
ff68426
Name the protocol version types
Ericson2314 Oct 17, 2023
e36c917
Add protocol versions to `{Worker,Serve}Proto::*Conn`
Ericson2314 Mar 25, 2022
a0f071f
store info sh renamed
vicky1999 Oct 17, 2023
891dfb4
updated store ping to store info in files
vicky1999 Oct 17, 2023
9d1f42d
Merge pull request #9150 from vicky1999/fix/8914
Ericson2314 Oct 18, 2023
c1a1766
Merge pull request #9169 from vkryachko/follow_cycle
thufschmitt Oct 18, 2023
201c115
Merge pull request #9151 from edolstra/stabilize-fetchTree
edolstra Oct 18, 2023
e9ddf0b
Simplify parseHashTypeOpt
ShamrockLee Oct 9, 2023
aff177d
Elaborate the "unknown hash algorithm" error
ShamrockLee Oct 9, 2023
838c70f
treewide: Rename hashBase to hashFormat
ShamrockLee Oct 10, 2023
5043e6c
Document HashFormat
ShamrockLee Oct 18, 2023
e026f3e
treewide: Reference HashFormat members with scope
ShamrockLee Oct 13, 2023
231b0fc
Migrate HashFormat to scoped enumeration (enum struct)
ShamrockLee Oct 13, 2023
6b47635
Add helper function parseHashFormat[Opt] printHashFormat
ShamrockLee Oct 9, 2023
5088e65
primops: add builtins.convertHash
ShamrockLee Jan 29, 2023
34c5593
add a link to all maintainer meeting notes
fricklerhandwerk Oct 19, 2023
8b48fb1
Merge pull request #7708 from ShamrockLee/primop-rebasehash
fricklerhandwerk Oct 19, 2023
9adac23
update link to label
fricklerhandwerk Oct 19, 2023
36b15d9
link to popular issues from the contributing guide
fricklerhandwerk Oct 19, 2023
9bc7b4f
doc: generic closure supported key types (#9183)
hsjobeki Oct 19, 2023
ce42655
Merge pull request #9180 from fricklerhandwerk/meeting-notes-link
Ericson2314 Oct 19, 2023
6016a0e
Merge pull request #9181 from fricklerhandwerk/good-first-issue-label
Ericson2314 Oct 19, 2023
7ed294f
Merge pull request #9182 from fricklerhandwerk/popular-issues
Ericson2314 Oct 19, 2023
42f26eb
doc: complexity for '?' operator (#9184)
hsjobeki Oct 20, 2023
e58566a
doc: add reference to hasAttr in `?` operator (#9185)
hsjobeki Oct 20, 2023
9277eb2
libstore: Add apple-virt to system features when available
roberth Oct 19, 2023
bb645c5
system-features doc: kvm is Linux-only
roberth Oct 20, 2023
8a28ed2
Merge pull request #9187 from hercules-ci/issue-7619-apple-virt-syste…
Ericson2314 Oct 20, 2023
4d17c59
Merge pull request #9157 from obsidiansystems/protocol-versions
roberth Oct 20, 2023
af30226
Input::hasAllInfo(): Remove
edolstra Oct 20, 2023
3e6b9f9
Remove `prevInfos` as its dead code
Ericson2314 Oct 16, 2023
862d164
Remove the `ValidPathInfo` `==` operator
Ericson2314 Oct 16, 2023
e824ab3
Merge pull request #9195 from edolstra/remove-hasAllInfo
edolstra Oct 20, 2023
0f7e9d0
Input: Remove 'direct' field
edolstra Oct 20, 2023
85e5ac4
docker: publish images to ghcr.io (#8066)
baloo Oct 20, 2023
81ed1d5
Merge pull request #9197 from obsidiansystems/delete-dead-code
Ericson2314 Oct 20, 2023
091e5b4
Merge pull request #9198 from edolstra/remove-direct
edolstra Oct 20, 2023
935c998
Remove fetchers::Tree and move tarball-related stuff into its own header
edolstra Oct 20, 2023
7d3cd54
Merge pull request #9199 from edolstra/remove-tree
edolstra Oct 20, 2023
97a0c08
Expand derivation examples (#9048)
fricklerhandwerk Oct 20, 2023
5135e47
fix: adl_serializer for std::optional
aakropotkin Oct 21, 2023
3f0af2d
additional test cases
aakropotkin Oct 21, 2023
7ace482
restore static_asserts
aakropotkin Oct 21, 2023
7f18ed8
Merge branch 'patch-1' into nlohmann-optional
aakropotkin Oct 21, 2023
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
link to popular issues from the contributing guide
this also adds a hint to contributors about making far-reaching changes,
complementing the recent update to the maintainers' handbook on how to
deal with those.
  • Loading branch information
fricklerhandwerk committed Oct 19, 2023
commit 36b15d905e8ca6f5eb4f73fb842600b6e091708e
3 changes: 3 additions & 0 deletions CONTRIBUTING.md
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,9 @@ Check out the [security policy](https://github.com/NixOS/nix/security/policy).
Issues labeled [good first issue](https://github.com/NixOS/nix/labels/good-first-issue) should be relatively easy to fix and are likely to get merged quickly.
Pull requests addressing issues labeled [idea approved](https://github.com/NixOS/nix/labels/idea%20approved) or [RFC](https://github.com/NixOS/nix/labels/RFC) are especially welcomed by maintainers and will receive prioritised review.

If you are proficient with C++, addressing one of the [popular issues](https://github.com/NixOS/nix/issues?q=is%3Aissue+is%3Aopen+sort%3Areactions-%2B1-desc) will be highly appreciated by maintainers and Nix users all over the world.
For far-reaching changes, please investigate possible blockers and design implications, and coordinate with maintainers before investing too much time in writing code that may not end up getting merged.

If there is no relevant issue yet and you're not sure whether your change is likely to be accepted, [open an issue](https://github.com/NixOS/nix/issues/new/choose) yourself.

2. Check for [pull requests](https://github.com/NixOS/nix/pulls) that might already cover the contribution you are about to make.
Expand Down