fix (@aws-amplify/storage) - track property (aws-amplify#6425)

* fix typeError on putEvents * update test Co-authored-by: Jordan Ranz <[email protected]>
abdielou · Jul 27, 2020 · 2009e1d · 2009e1d
1 parent 28efe52
commit 2009e1d
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 5 deletions.
diff --git a/packages/storage/__tests__/providers/AWSS3Provider-unit-test.ts b/packages/storage/__tests__/providers/AWSS3Provider-unit-test.ts
@@ -206,7 +206,6 @@ describe('StorageProvider test', () => {
 					event: 'getSignedUrl',
 					data: {
 						attrs: { method: 'get', result: 'success' },
-						metrics: null,
 					},
 					message: 'Signed URL: url',
 				},
@@ -505,7 +504,6 @@ describe('StorageProvider test', () => {
 							method: 'put',
 							result: 'success',
 						},
-						metrics: null,
 					},
 					message: 'Upload success for key',
 				},
@@ -627,7 +625,6 @@ describe('StorageProvider test', () => {
 					event: 'delete',
 					data: {
 						attrs: { method: 'remove', result: 'success' },
-						metrics: null,
 					},
 					message: 'Deleted key successfully',
 				},
@@ -781,7 +778,6 @@ describe('StorageProvider test', () => {
 					event: 'list',
 					data: {
 						attrs: { method: 'list', result: 'success' },
-						metrics: null,
 					},
 					message: '1 items returned from list operation',
 				},

diff --git a/packages/storage/src/providers/AWSS3Provider.ts b/packages/storage/src/providers/AWSS3Provider.ts
@@ -46,11 +46,15 @@ const dispatchStorageEvent = (
 	message: string
 ) => {
 	if (track) {
+		const data = { attrs };
+		if (metrics) {
+			data['metrics'] = metrics;
+		}
 		Hub.dispatch(
 			'storage',
 			{
 				event,
-				data: { attrs, metrics },
+				data,
 				message,
 			},
 			'Storage',