code review comments and refactoring.

abduljaleel · Mar 25, 2019 · 36fb9f1 · 36fb9f1
1 parent 316df65
commit 36fb9f1
Show file tree

Hide file tree

Showing 49 changed files with 743 additions and 2,240 deletions.
diff --git a/Gopkg.lock b/Gopkg.lock
diff --git a/cmd/main.go b/cmd/main.go
@@ -2,6 +2,7 @@ package main
 
 import (
 	"flag"
+	"os"
 	"time"
 
 	adapter "github.com/Azure/Kore/pkg/adapter"
@@ -31,6 +32,7 @@ func main() {
 	adapter := &adapter.KoreAdapter{}
 	adapter.Flags().StringVar(&adapter.Message, "msg", "starting adapter...", "startup message")
 	adapter.Flags().AddGoFlagSet(flag.CommandLine)
+	adapter.Flags().Parse(os.Args)
 
 	parsedLogLevel, err := log.ParseLevel(*logLevel)
 	if err == nil {

diff --git a/deploy/KoreScaleController.yaml b/deploy/KoreScaleController.yaml
@@ -13,13 +13,13 @@ spec:
 apiVersion: v1
 kind: Namespace
 metadata:
-  name: custom-metrics
+  name: kore
 ---
 kind: ServiceAccount
 apiVersion: v1
 metadata:
   name: service-controller
-  namespace: custom-metrics
+  namespace: kore
 ---
 apiVersion: rbac.authorization.k8s.io/v1
 kind: ClusterRoleBinding
@@ -32,25 +32,25 @@ roleRef:
 subjects:
 - kind: ServiceAccount
   name: service-controller
-  namespace: custom-metrics
+  namespace: kore
 ---
 apiVersion: rbac.authorization.k8s.io/v1
 kind: ClusterRoleBinding
 metadata:
-  name: custom-metrics:system:auth-delegator
+  name: kore:system:auth-delegator
 roleRef:
   apiGroup: rbac.authorization.k8s.io
   kind: ClusterRole
   name: system:auth-delegator
 subjects:
 - kind: ServiceAccount
   name: service-controller
-  namespace: custom-metrics
+  namespace: kore
 ---
 apiVersion: rbac.authorization.k8s.io/v1
 kind: RoleBinding
 metadata:
-  name: custom-metrics-auth-reader
+  name: kore-auth-reader
   namespace: kube-system
 roleRef:
   apiGroup: rbac.authorization.k8s.io
@@ -59,15 +59,15 @@ roleRef:
 subjects:
 - kind: ServiceAccount
   name: service-controller
-  namespace: custom-metrics
+  namespace: kore
 ---
 apiVersion: apps/v1
 kind: Deployment
 metadata:
   labels:
     app: service-controller
   name: service-controller
-  namespace: custom-metrics
+  namespace: kore
 spec:
   replicas: 1
   selector:
@@ -111,13 +111,13 @@ roleRef:
 subjects:
 - kind: ServiceAccount
   name: service-controller
-  namespace: custom-metrics
+  namespace: kore
 ---
 apiVersion: v1
 kind: Service
 metadata:
   name: service-controller
-  namespace: custom-metrics
+  namespace: kore
 spec:
   ports:
   - name: https
@@ -136,7 +136,7 @@ metadata:
 spec:
   service:
     name: service-controller
-    namespace: custom-metrics
+    namespace: kore
   group: custom.metrics.k8s.io
   version: v1beta1
   insecureSkipTLSVerify: true
@@ -150,7 +150,7 @@ metadata:
 spec:
   service:
     name: service-controller
-    namespace: custom-metrics
+    namespace: kore
   group: external.metrics.k8s.io
   version: v1beta1
   insecureSkipTLSVerify: true
@@ -194,4 +194,4 @@ roleRef:
 subjects:
 - kind: ServiceAccount
   name: horizontal-pod-autoscaler
-  namespace: kube-system
+  namespace: kube-system