Skip to content

Commit

Permalink
Fix in accounts receivable report
Browse files Browse the repository at this point in the history
  • Loading branch information
nabinhait committed Feb 5, 2014
1 parent 18eb8c5 commit a7af1d6
Show file tree
Hide file tree
Showing 5 changed files with 13 additions and 12 deletions.
6 changes: 2 additions & 4 deletions accounts/report/accounts_receivable/accounts_receivable.py
Original file line number Diff line number Diff line change
Expand Up @@ -113,9 +113,8 @@ def get_account_map(self):
if not hasattr(self, "account_map"):
self.account_map = dict(((r.name, r) for r in webnotes.conn.sql("""select
acc.name, cust.name as customer, cust.customer_name, cust.territory
from `tabAccount` acc, `tabCustomer` cust
where acc.master_type="Customer"
and cust.name=acc.master_name""", as_dict=True)))
from `tabAccount` acc left join `tabCustomer` cust
on cust.name=acc.master_name where acc.master_type="Customer" """, as_dict=True)))

return self.account_map

Expand All @@ -134,7 +133,6 @@ def get_gl_entries(self):
self.gl_entries = webnotes.conn.sql("""select * from `tabGL Entry`
where docstatus < 2 {0} order by posting_date, account""".format(conditions),
values, as_dict=True)

return self.gl_entries

def prepare_conditions(self):
Expand Down
13 changes: 8 additions & 5 deletions accounts/utils.py
Original file line number Diff line number Diff line change
Expand Up @@ -356,20 +356,23 @@ def get_actual_expense(args):
and fiscal_year='%(fiscal_year)s' and company='%(company)s' %(condition)s
""" % (args))[0][0]

def rename_account_for(dt, olddn, newdn, merge):
def rename_account_for(dt, olddn, newdn, merge, company):
old_account = get_account_for(dt, olddn)
if old_account:
new_account = None
if not merge:
if old_account == olddn:
new_account = webnotes.rename_doc("Account", olddn, newdn)
if old_account == add_abbr_if_missing(olddn, company):
new_account = webnotes.rename_doc("Account", old_account, newdn)
else:
existing_new_account = get_account_for(dt, newdn)
new_account = webnotes.rename_doc("Account", old_account,
existing_new_account or newdn, merge=True if existing_new_account else False)

if new_account:
webnotes.conn.set_value("Account", new_account, "master_name", newdn)
webnotes.conn.set_value("Account", new_account or old_account, "master_name", newdn)

def add_abbr_if_missing(dn, company):
from setup.doctype.company.company import get_name_with_abbr
return get_name_with_abbr(dn, company)

def get_account_for(account_for_doctype, account_for):
if account_for_doctype in ["Customer", "Supplier"]:
Expand Down
2 changes: 1 addition & 1 deletion buying/doctype/supplier/supplier.py
Original file line number Diff line number Diff line change
Expand Up @@ -161,7 +161,7 @@ def on_trash(self):

def before_rename(self, olddn, newdn, merge=False):
from accounts.utils import rename_account_for
rename_account_for("Supplier", olddn, newdn, merge)
rename_account_for("Supplier", olddn, newdn, merge, self.doc.company)

def after_rename(self, olddn, newdn, merge=False):
set_field = ''
Expand Down
2 changes: 1 addition & 1 deletion selling/doctype/customer/customer.py
Original file line number Diff line number Diff line change
Expand Up @@ -156,7 +156,7 @@ def on_trash(self):

def before_rename(self, olddn, newdn, merge=False):
from accounts.utils import rename_account_for
rename_account_for("Customer", olddn, newdn, merge)
rename_account_for("Customer", olddn, newdn, merge, self.doc.company)

def after_rename(self, olddn, newdn, merge=False):
set_field = ''
Expand Down
2 changes: 1 addition & 1 deletion stock/doctype/warehouse/warehouse.py
Original file line number Diff line number Diff line change
Expand Up @@ -102,7 +102,7 @@ def before_rename(self, olddn, newdn, merge=False):
webnotes.conn.sql("delete from `tabBin` where warehouse=%s", olddn)

from accounts.utils import rename_account_for
rename_account_for("Warehouse", olddn, newdn, merge)
rename_account_for("Warehouse", olddn, newdn, merge, self.doc.company)

return newdn

Expand Down

0 comments on commit a7af1d6

Please sign in to comment.