Remove clearVisibilityItemsOnlyWhenDirty experiment

Summary: This is the correct thing to do, we don't need to assess impact any more.

Reviewed By: marco-cova

Differential Revision: D9420682

fbshipit-source-id: 1cbfb1af80a2f5f95d794013960c39d0f41bc135

litho-core/src/main/java/com/facebook/litho/MountState.java

@@ -507,8 +507,6 @@ private void processVisibilityOutputs(
     final boolean isDoingPerfLog = mMountStats.isLoggingEnabled;
     final boolean isTracing = ComponentsSystrace.isTracing();
     final long totalStartTime = isDoingPerfLog ? System.nanoTime() : 0L;
-    final boolean clearRemovedVisibilityItems =
-        mIsDirty || !ComponentsConfiguration.clearVisibilityItemsOnlyWhenDirty;
     for (int j = 0, size = layoutState.getVisibilityOutputCount(); j < size; j++) {
       final VisibilityOutput visibilityOutput = layoutState.getVisibilityOutputAt(j);
       if (isTracing) {
@@ -572,7 +570,7 @@ private void processVisibilityOutputs(
           visibilityItem = null;
         } else {
           // Processed, do not clear.
-          visibilityItem.setDoNotClearInThisPass(clearRemovedVisibilityItems);
+          visibilityItem.setDoNotClearInThisPass(mIsDirty);
         }
       }
 
@@ -585,7 +583,7 @@ private void processVisibilityOutputs(
                   : null;
           visibilityItem =
               ComponentsPools.acquireVisibilityItem(globalKey, invisibleHandler, unfocusedHandler);
-          visibilityItem.setDoNotClearInThisPass(clearRemovedVisibilityItems);
+          visibilityItem.setDoNotClearInThisPass(mIsDirty);
           mVisibilityIdToItemMap.put(visibilityOutputId, visibilityItem);
 
           if (visibleHandler != null) {
@@ -634,7 +632,7 @@ private void processVisibilityOutputs(
       }
     }
 
-    if (clearRemovedVisibilityItems) {
+    if (mIsDirty) {
       clearVisibilityItems();
     }
 

litho-core/src/main/java/com/facebook/litho/config/ComponentsConfiguration.java

@@ -179,10 +179,7 @@ public class ComponentsConfiguration {
 
   public static boolean useNewIsEquivalentTo = false;
 
-  /** Only clear visibility items in MountState when the MountState is dirty */
-  public static boolean clearVisibilityItemsOnlyWhenDirty = true;
-
-  /** Assess the impact of using the Thrawable class to track crashes across threads */
+  /** Assess the impact of using the Throwable class to track crashes across threads */
   public static boolean enableThrowableTracking = false;
 
   /** Whether we should do incremental mount on pre draw */