Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compat Aegis - Remove EHP from Beanies #10713

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Conversation

BrettMayson
Copy link
Member

When merged this pull request will:
image

IMPORTANT

  • If the contribution affects the documentation, please include your changes in this pull request so the documentation will appear on the website.
  • Development Guidelines are read, understood and applied.
  • Title of this PR uses our standard template Component - Add|Fix|Improve|Change|Make|Remove {changes}.

@LinkIsGrim LinkIsGrim added the kind/bug-fix Release Notes: **FIXED:** label Feb 3, 2025
@LinkIsGrim LinkIsGrim added this to the 3.19.1 milestone Feb 3, 2025
@PabstMirror
Copy link
Contributor

H_Watchcap_blk for me has little ear plugs in both ears
20250203192742_1

@BrettMayson
Copy link
Member Author

BrettMayson commented Feb 4, 2025

I think we'll need to add an exception in the code for this then, the headset and non-headset variants must both inherit from this

@LinkIsGrim
Copy link
Contributor

Ref #10469

@PabstMirror
Copy link
Contributor

Where does the non-earplug beanie come from?

@LinkIsGrim
Copy link
Contributor

Where does the non-earplug beanie come from?

Aegis. Fun.

@PabstMirror
Copy link
Contributor

I guess we can just add ehp=0 to our aegis compat?

@LinkIsGrim
Copy link
Contributor

Aegis still has a headset variant available in H_Watchcap_blk_hs that inherits from H_Watchcap_blk. I'm handling that, boonies are probably also changed but I'm not up to redownloading it and checking. Going to outsource that to Discord.

@PabstMirror PabstMirror changed the title Hearing - Remove EHP from Beanies Compat Aegis - Remove EHP from Beanies Feb 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug-fix Release Notes: **FIXED:**
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants