Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add flutter sdk 3.24 support #81

Conversation

DmitryGaimaldinov
Copy link

Adding compileOptions and kotlinOptions fixes #79. Upgrading compileSdk fixes #78

Similar issues in another libs: OneSignal/OneSignal-Flutter-SDK#930

@richardradics
Copy link

@DmitryGaimaldinov is it possible to try this branch in my project before it's merged?
If I add your branch like this:

  flutter_libphonenumber:
    git:
      url: https://github.com/DmitryGaimaldinov/flutter_libphonenumber.git
      ref: support/flutter_3.24.0

I receive the following error:

Resolving dependencies...
Error on line 1, column 7: "name" field doesn't match expected name "flutter_libphonenumber".
  ╷
1 │ name: flutter_libphonenumber_workspace

@DmitryGaimaldinov
Copy link
Author

DmitryGaimaldinov commented Aug 16, 2024

@richardradics this error happens because flutter_libphonenumber uses melos for packaging. Original package from pub dev is in https://github.com/acoutts/flutter_libphonenumber/packages/flutter_libphonenumber directory (internal directory of https://github.com/acoutts/flutter_libphonenumber). And it's name flutter_libphonenumber. At the same time the main repo https://github.com/acoutts/flutter_libphonenumber has name flutter_libphonenumber_workspace.

I've changed build.gradle inside flutter_libphonenumber_android folder but the package refers internally to flutter_libphonenumber_android: ^1.0.2 which will be next version of https://pub.dev/packages/flutter_libphonenumber_android. So it doesn't use flutter_libphonenumber_android from this fork.

If you want to use this fork before merge I've made another branch for you. But I don't suggest using it. It's better to remain on flutter 3.22 and wait for response.

  flutter_libphonenumber:
    git:
      url: https://github.com/DmitryGaimaldinov/flutter_libphonenumber.git
      ref: support/flutter_3.24.0_fork
      path: packages/flutter_libphonenumber

@acoutts
Copy link
Owner

acoutts commented Aug 19, 2024

this should be fixed now as of 2.3.1

@acoutts acoutts closed this Sep 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Resource android:attr/lStar not found Support flutter 3.24
3 participants