Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add e2e testing guide #1126

Merged
merged 6 commits into from
Feb 11, 2025
Merged

Add e2e testing guide #1126

merged 6 commits into from
Feb 11, 2025

Conversation

cquinn540
Copy link
Collaborator

@cquinn540 cquinn540 commented Feb 11, 2025

Contributor checklist


Description

This adds a guide for writing e2e tests to our documentation. The focus is on the patterns we are using and why.

Related issue

Copy link

netlify bot commented Feb 11, 2025

Deploy Preview for activist-org canceled.

Name Link
🔨 Latest commit ed4a16c
🔍 Latest deploy log https://app.netlify.com/sites/activist-org/deploys/67abd2fae2347d00084f6115

Copy link
Contributor

Thank you for the pull request! ❤️

The activist team will do our best to address your contribution as soon as we can. If you're not already a member of our public Matrix community, please consider joining! We'd suggest using Element as your Matrix client, and definitely join the General and Development rooms once you're in. Also consider attending our bi-weekly Saturday developer syncs! It'd be great to meet you 😊

Copy link
Contributor

github-actions bot commented Feb 11, 2025

Maintainer Checklist

The following is a checklist for maintainers to make sure this process goes as well as possible. Feel free to address the points below yourself in further commits if you realize that actions are needed :)

  • The TypeScript and formatting workflows within the PR checks do not indicate new errors in the files changed

  • The Playwright end to end and Zap penetration tests have been ran and are passing (if necessary)

  • The changelog has been updated with a description of the changes for the upcoming release and the corresponding issue (if necessary)

@andrewtavis andrewtavis self-requested a review February 11, 2025 21:43
Copy link
Member

@andrewtavis andrewtavis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the documentation here, @cquinn540! Happy to have this finalized :) I did some minor edits, with the most significant being removing periods from unordered lists. Till now we haven't been using them, and I figure it's best to be consistent.

@andrewtavis andrewtavis merged commit 8fe36eb into activist-org:main Feb 11, 2025
7 checks passed
@cquinn540 cquinn540 deleted the e2e-guide branch February 12, 2025 17:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants