Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhance: context menu on custom reports page #3776

Open
wants to merge 11 commits into
base: master
Choose a base branch
from
Open

enhance: context menu on custom reports page #3776

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
96b744b
enhance: context menu on custom reports page
UnderKoen Oct 30, 2024
e39e453
chore: release note
UnderKoen Nov 3, 2024
2df910e
chore: lint
UnderKoen Nov 3, 2024
4506b85
chore: use both feature flags
UnderKoen Nov 12, 2024
3e21feb
Merge remote-tracking branch 'origin/master' into enhancement/context…
UnderKoen Nov 12, 2024
41d9b14
chore: use both feature flags
UnderKoen Nov 12, 2024
ec5e83f
chore: pr feedback
UnderKoen Nov 26, 2024
1c13cd0
Merge remote-tracking branch 'origin/master' into enhancement/context…
UnderKoen Nov 26, 2024
9a21ace
Merge branch 'refs/heads/master' into enhancement/context_menus/repor…
UnderKoen Dec 9, 2024
568cd77
fix: changing name with context menu
UnderKoen Dec 17, 2024
49abfd1
Merge branch 'master' into enhancement/context_menus/reports_page
UnderKoen Dec 17, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
chore: pr feedback
  • Loading branch information
@UnderKoen
UnderKoen committed Nov 26, 2024
commit ec5e83fde176957b285d0d3e81c1afc81ffa69a3
4 changes: 2 additions & 2 deletions packages/desktop-client/src/components/reports/ReportCard.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -124,9 +124,9 @@ function Layout({ children, isEditing, menuItems, onMenuSelect }: LayoutProps) {
const [menuOpen, setMenuOpen] = useState<null | 'context' | 'button'>(null);
const [crossOffset, setCrossOffset] = useState(0);
const [offset, setOffset] = useState(0);
const reportBudgetEnabled = useFeatureFlag('reportBudget');
const dashboardsEnabled = useFeatureFlag('dashboards');
const contextMenusEnabled =
useFeatureFlag('contextMenus') && reportBudgetEnabled;
useFeatureFlag('contextMenus') && dashboardsEnabled;

const isContextMenu = menuOpen === 'context';

Expand Down
2 changes: 1 addition & 1 deletion upcoming-release-notes/3776.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,4 +3,4 @@ category: Enhancements
authors: [UnderKoen]
---

Add context menu's to custom reports dashboard
Add context menus to custom reports dashboard