Enactment: enable triggering of rules on selected transaction form the account view.

packages/desktop-client/src/components/accounts/Account.tsx

@@ -44,6 +44,7 @@ import {
   type RuleConditionEntity,
   type TransactionEntity,
   type TransactionFilterEntity,
+  type RuleEntity,
 } from 'loot-core/src/types/models';
 
 import { useAccounts } from '../../hooks/useAccounts';
@@ -705,6 +706,29 @@ class AccountInternal extends PureComponent<
     return groupById<{ id: string; balance: number }>(data);
   }
 
+  onRunRules = async (ids: string[]) => {
+    // this should be probably inside the onEdit function that the others button are calling
+    // but I'm not sure how to do it and if i'll break anything
+    const transactions = this.state.transactions;
+    for (const transId of ids) {
+      const trans = transactions.find(({ id }) => transId === id);
+      send('payees-get-rules', {
+        id: trans.payee,
+      }).then((the_rules: RuleEntity[]) => {
+        the_rules.forEach((rule: RuleEntity) => {
+          send('rule-apply-actions', {
+            transactions: [trans],
+            actions: rule.actions,
+          }).then(() => {
+            // once rule is applied, fetch the transaction again.
+            // should just update the one that has been updated, but not sure how to do it.
+            // probably via the updateTransaction function ?
+            this.fetchTransactions();
+          });
+        });
+      });
+    }
+  };
   onAddTransaction = () => {
     this.setState({ isAdding: true });
   };
@@ -1736,6 +1760,7 @@ class AccountInternal extends PureComponent<
                 onImport={this.onImport}
                 onBatchDelete={this.onBatchDelete}
                 onBatchDuplicate={this.onBatchDuplicate}
+                onRunRules={this.onRunRules}
                 onBatchEdit={this.onBatchEdit}
                 onBatchLinkSchedule={this.onBatchLinkSchedule}
                 onBatchUnlinkSchedule={this.onBatchUnlinkSchedule}

packages/desktop-client/src/components/accounts/Header.tsx

@@ -95,6 +95,7 @@ type AccountHeaderProps = {
   onMenuSelect: AccountMenuProps['onMenuSelect'];
   onReconcile: ComponentProps<typeof ReconcileMenu>['onReconcile'];
   onBatchEdit: ComponentProps<typeof SelectedTransactionsButton>['onEdit'];
+  onRunRules: ComponentProps<typeof SelectedTransactionsButton>['onRunRules'];
   onBatchDelete: ComponentProps<typeof SelectedTransactionsButton>['onDelete'];
   onBatchDuplicate: ComponentProps<
     typeof SelectedTransactionsButton
@@ -177,6 +178,7 @@ export function AccountHeader({
   onDeleteFilter,
   onScheduleAction,
   onSetTransfer,
+  onRunRules,
   onMakeAsSplitTransaction,
   onMakeAsNonSplitTransactions,
 }: AccountHeaderProps) {
@@ -359,6 +361,7 @@ export function AccountHeader({
               onDuplicate={onBatchDuplicate}
               onDelete={onBatchDelete}
               onEdit={onBatchEdit}
+              onRunRules={onRunRules}
               onLinkSchedule={onBatchLinkSchedule}
               onUnlinkSchedule={onBatchUnlinkSchedule}
               onCreateRule={onCreateRule}

packages/desktop-client/src/components/transactions/SelectedTransactionsButton.tsx

@@ -31,6 +31,7 @@ type SelectedTransactionsButtonProps = {
   onLinkSchedule: (selectedIds: string[]) => void;
   onUnlinkSchedule: (selectedIds: string[]) => void;
   onCreateRule: (selectedIds: string[]) => void;
+  onRunRules: (selectedIds: string[]) => void;
   onSetTransfer: (selectedIds: string[]) => void;
   onScheduleAction: (
     action: 'post-transaction' | 'skip',
@@ -50,6 +51,7 @@ export function SelectedTransactionsButton({
   onLinkSchedule,
   onUnlinkSchedule,
   onCreateRule,
+  onRunRules,
   onSetTransfer,
   onScheduleAction,
   showMakeTransfer,
@@ -193,6 +195,10 @@ export function SelectedTransactionsButton({
     onEdit,
     selectedIds,
   ]);
+  useHotkeys('r', () => onRunRules(selectedIds), hotKeyOptions, [
+    onRunRules,
+    selectedIds,
+  ]);
   useHotkeys(
     's',
     () =>
@@ -253,7 +259,13 @@ export function SelectedTransactionsButton({
                       name: 'create-rule',
                       text: t('Create rule'),
                     } as const,
+                    {
+                      name: 'run-rules',
+                      text: t('Run Rules'),
+                      key: 'R',
+                    } as const,
                   ]),
+
               ...(showMakeTransfer
                 ? [
                     {
@@ -325,6 +337,9 @@ export function SelectedTransactionsButton({
           case 'create-rule':
             onCreateRule(selectedIds);
             break;
+          case 'run-rules':
+            onRunRules(selectedIds);
+            break;
           case 'set-transfer':
             onSetTransfer(selectedIds);
             break;

upcoming-release-notes/3805.md

@@ -0,0 +1,6 @@
+---
+category: Enhancements
+authors: [esseti]
+---
+
+Enables rule activation from the account view via dropdown menu or by pressing 'R'