[Redux Toolkit Migration] Use new Redux Toolkit configureStore API #4000
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
actual-github-bot
bot
changed the title
✅ Deploy Preview for actualbudget ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
joel-jeremy
force-pushed
the
redux-toolkit
branch
from
546d614 to
c53deaf
Compare
Bundle Stats — desktop-clientHey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle. As this PR is updated, I'll keep you updated on how the bundle size is impacted. Total
Changeset (largest 100 files by percent change)
View detailed bundle breakdownAdded No assets were added Removed No assets were removed Bigger
Smaller
Unchanged
|
Bundle Stats — loot-coreHey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle. As this PR is updated, I'll keep you updated on how the bundle size is impacted. Total
Changeset No files were changed View detailed bundle breakdownAdded No assets were added Removed No assets were removed Bigger No assets were bigger Smaller No assets were smaller Unchanged
|
|
/update-vrt |
joel-jeremy
commented
Dec 18, 2024
| @@ -11,6 +11,7 @@ const currentUndoState: T.UndoState = { | |||
| url: null, | |||
| openModal: null, | |||
| selectedItems: null, | |||
| current: null, | |||
There was a problem hiding this comment.
Moved from redux state.app.lastUndoState to here
| @@ -8,6 +8,7 @@ export type UndoState = { | |||
| name: string; | |||
| items: Set<string>; | |||
| } | null; | |||
| current: unknown; | |||
There was a problem hiding this comment.
Moved from redux state.app.lastUndoState to here
| // Reset the state and only keep around things intentionally. This | ||
| // blows away everything else | ||
| state = { | ||
| account: initialAccountState, |
There was a problem hiding this comment.
TS is complaining about the missing state properties so I have set them to initial states instead.
| @@ -1,7 +1,7 @@ | |||
| import type * as constants from '../constants'; | |||
|
|
|||
| export type AccountState = { | |||
| failedAccounts: Map<string, { type: string; code: string }>; | |||
| failedAccounts: { [key: string]: { type: string; code: string } }; | |||
There was a problem hiding this comment.
Changed to object because redux toolkit complains that Map is non-serializable
| @@ -18,17 +16,6 @@ export function update(state = initialState, action: Action): AppState { | |||
| ...state, | |||
| ...action.state, | |||
| }; | |||
| case constants.SET_LAST_UNDO_STATE: | |||
There was a problem hiding this comment.
Removed from redux state and moved to loot-core/platform/client/undo since redux toolkit is complaining that it's mutating in the reducer
| state.lastUndoState.current = action.undoState; | ||
| return state; | ||
|
|
||
| case constants.SET_LAST_SPLIT_STATE: |
There was a problem hiding this comment.
Removed from redux state and moved to useSplitExpanded since redux toolkit is complaining that it's mutating in the reducer
| @@ -2,8 +2,8 @@ import * as constants from '../constants'; | |||
| import type { Action } from '../state-types'; | |||
| import type { AccountState } from '../state-types/account'; | |||
|
|
|||
| const initialState: AccountState = { | |||
| failedAccounts: new Map(), | |||
There was a problem hiding this comment.
Changed from Map to object since redux toolkit is complaining that Map is non-serializable
| @@ -59,7 +59,7 @@ type SplitsStateContext = { | |||
| const SplitsExpandedContext = createContext<SplitsStateContext>({ | |||
| state: { | |||
| mode: 'collapse', | |||
| ids: new Set(), | |||
There was a problem hiding this comment.
Changed from Set to array since redux toolkit is complaining that Set is non-serializable
joel-jeremy
changed the title
joel-jeremy
changed the title
joel-jeremy
force-pushed
the
redux-toolkit
branch
from
5b062e2 to
dd92cb3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Initial migration to redux-toolkit. This PR focuses on retrofitting the existing reducers to the newer redux toolkit APIs. We can work on converting them to redux slices in a future PR.
Aside from converting to the usage of typed
useAppDispatcheranduseAppSelector, I had to do some changes to theSET_LAST_UNDO_STATEandSET_LAST_SPLIT_STATEto prevent mutating the state in their reducers because redux toolkit now check for that.There are still some redux validation errors due to non-serializable values being on the the state e.g. modal callback functions. But I have disabled those checks temporarily until we can address them in a future PR.
configureStoreAPISET_LAST_UNDO_STATE,SET_LAST_SPLIT_STATE)createSliceAPIcreateAsyncThunkAPI