Merge pull request blevesearch#1108 from abhinavdangeti/minMaxKey

[Scorch] Skipping segments that don't include requested ids
adaiboy · Jan 16, 2019 · d725210 · d725210
2 parents d04890d + 5554236
commit d725210
Showing 1 changed file with 13 additions and 0 deletions.
diff --git a/index/scorch/segment/zap/segment.go b/index/scorch/segment/zap/segment.go
@@ -418,7 +418,20 @@ func (s *SegmentBase) DocNumbers(ids []string) (*roaring.Bitmap, error) {
 		}
 
 		postingsList := emptyPostingsList
+
+		sMax, err := idDict.fst.GetMaxKey()
+		if err != nil {
+			return nil, err
+		}
+		sMaxStr := string(sMax)
+		filteredIds := make([]string, 0, len(ids))
 		for _, id := range ids {
+			if id <= sMaxStr {
+				filteredIds = append(filteredIds, id)
+			}
+		}
+
+		for _, id := range filteredIds {
 			postingsList, err = idDict.postingsList([]byte(id), nil, postingsList)
 			if err != nil {
 				return nil, err