Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make use of Faraday::GetMethodOverride optional #211

Merged
merged 4 commits into from
Jul 10, 2016

Conversation

rhymes
Copy link
Contributor

@rhymes rhymes commented Jul 8, 2016

I made this middleware optional, so that it can be deactivated.

It still defaults to true because that's why previous users of the library expect. We should consider switching it to false at some point.

Closes #210

@coveralls
Copy link

coveralls commented Jul 8, 2016

Coverage Status

Coverage increased (+0.002%) to 98.07% when pulling cb434c2 on optional-method-override into 9b79ec7 on master.

@coveralls
Copy link

coveralls commented Jul 8, 2016

Coverage Status

Coverage increased (+0.004%) to 98.073% when pulling 087f7c3 on optional-method-override into 9b79ec7 on master.

@coveralls
Copy link

coveralls commented Jul 9, 2016

Coverage Status

Coverage increased (+0.004%) to 98.07% when pulling 4c1f6c1 on optional-method-override into da81f45 on master.

@coveralls
Copy link

coveralls commented Jul 9, 2016

Coverage Status

Coverage increased (+0.004%) to 98.07% when pulling 2ea35f6 on optional-method-override into 5cd24ca on master.

@rhymes rhymes merged commit 0a78a77 into master Jul 10, 2016
@rhymes rhymes deleted the optional-method-override branch July 10, 2016 07:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants