Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(carousel): carousel and scrolling-list components #2566

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

Powerplex
Copy link
Contributor

TYPE(SCOPE): TITLE

TASK: SPA-239

Description, Motivation and Context

Carousel component:

A carousel is a user interface component that displays a collection of items, such as images or content cards, one (or a few) at a time within a single frame.

Users navigate through these items using controls like "Previous" and "Next" buttons or pagination indicators ("dots").

Carousels are ideal for presenting content sequentially, guiding users to focus on one item or group of items at a time.

ScrollingList component:

A scrolling list presents a series of items arranged horizontally or vertically, allowing users to explore the content by scrolling.

Each item maintains its natural size, which can result in varying dimensions and the possibility of partial visibility.

This format is suitable when offering an overview of available content, enabling users to quickly browse through a collection without a predefined structure.

Types of changes

  • ✨ New feature (non-breaking change which adds functionality)
  • 🧾 Documentation
  • 📷 Demo
  • 💄 Styles

Screenshots - Animations

carousel
scrolling-list

Copy link

codecov bot commented Jan 28, 2025

Codecov Report

Attention: Patch coverage is 65.67797% with 81 lines in your changes missing coverage. Please review.

Project coverage is 95.00%. Comparing base (03b27ce) to head (57ab2b4).
Report is 5 commits behind head on main.

Files with missing lines Patch % Lines
packages/components/carousel/src/useCarousel.ts 49.53% 54 Missing ⚠️
.../components/carousel/src/CarouselPageIndicator.tsx 16.66% 10 Missing ⚠️
packages/components/carousel/src/useIsVisible.ts 53.84% 6 Missing ⚠️
...ges/components/carousel/src/CarouselPagePicker.tsx 62.50% 2 Missing and 1 partial ⚠️
packages/components/carousel/src/CarouselSlide.tsx 77.77% 2 Missing ⚠️
...kages/components/carousel/src/useResizeObserver.ts 77.77% 2 Missing ⚠️
packages/components/carousel/src/Carousel.tsx 94.44% 1 Missing ⚠️
...ackages/components/carousel/src/CarouselSlides.tsx 87.50% 1 Missing ⚠️
packages/components/carousel/src/useScrollEnd.ts 87.50% 1 Missing ⚠️
...es/components/scrolling-list/src/ScrollingList.tsx 94.44% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2566      +/-   ##
==========================================
- Coverage   96.50%   95.00%   -1.51%     
==========================================
  Files         520      536      +16     
  Lines        4612     4848     +236     
  Branches     1644     1693      +49     
==========================================
+ Hits         4451     4606     +155     
- Misses        159      239      +80     
- Partials        2        3       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Powerplex Powerplex force-pushed the experimental-carousel branch from 40e6107 to 9611967 Compare February 6, 2025 16:36
@Powerplex Powerplex force-pushed the experimental-carousel branch from 9611967 to a3792a7 Compare February 7, 2025 15:38
@Powerplex Powerplex force-pushed the experimental-carousel branch from a3792a7 to 9c372c0 Compare February 7, 2025 15:53
@Powerplex Powerplex force-pushed the experimental-carousel branch from 9c372c0 to 06c7227 Compare February 7, 2025 16:54
@Powerplex Powerplex force-pushed the experimental-carousel branch from 06c7227 to 9275519 Compare February 10, 2025 11:19
@Powerplex Powerplex force-pushed the experimental-carousel branch from 9275519 to 2c6e491 Compare February 11, 2025 13:39
@Powerplex Powerplex force-pushed the experimental-carousel branch from 2c6e491 to b954bc7 Compare February 11, 2025 16:35
@Powerplex Powerplex force-pushed the experimental-carousel branch from b954bc7 to d07b730 Compare February 13, 2025 14:39
@Powerplex Powerplex force-pushed the experimental-carousel branch from d07b730 to eb1fc77 Compare February 13, 2025 14:52
@Powerplex Powerplex force-pushed the experimental-carousel branch from eb1fc77 to 0cbe3ae Compare February 14, 2025 14:14
@Powerplex Powerplex force-pushed the experimental-carousel branch from 0cbe3ae to 2d946c8 Compare February 14, 2025 14:21
@Powerplex Powerplex force-pushed the experimental-carousel branch from 2d946c8 to d81f8d2 Compare February 14, 2025 16:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant