Refactor FXIOS-5658 [v112] Update localized string from Sites to Pages (

mozilla-mobile#13207) * refact: Update string from Sites to Pages * refact: Change version to v112 * reafact: Adjust testConfigureGroupCell()
adityagi02 · Feb 21, 2023 · 6aa0c91 · 6aa0c91
1 parent 6279bbb
commit 6aa0c91
Show file tree

Hide file tree

Showing 4 changed files with 13 additions and 6 deletions.
diff --git a/.swiftpm/xcode/package.xcworkspace/contents.xcworkspacedata b/.swiftpm/xcode/package.xcworkspace/contents.xcworkspacedata
diff --git a/Client/Frontend/Browser/Tabs/ASGroup.swift b/Client/Frontend/Browser/Tabs/ASGroup.swift
@@ -34,7 +34,7 @@ extension ASGroup: HighlightItem {
     }
 
     var description: String? {
-        return String.localizedStringWithFormat(.FirefoxHomepage.Common.SitesCount, groupedItems.count)
+        return String.localizedStringWithFormat(.FirefoxHomepage.Common.PagesCount, groupedItems.count)
     }
 
     var siteUrl: URL? {

diff --git a/Client/Frontend/Strings.swift b/Client/Frontend/Strings.swift
@@ -179,11 +179,11 @@ extension String {
     /// Identifiers of all new strings should begin with `FirefoxHome.`
     public struct FirefoxHomepage {
         public struct Common {
-            public static let SitesCount = MZLocalizedString(
-                "FirefoxHomepage.Common.SitesCount.v101",
+            public static let PagesCount = MZLocalizedString(
+                "FirefoxHomepage.Common.PagesCount.v112",
                 tableName: nil,
-                value: "Sites: %d",
-                comment: "Label showing how many sites there is in a search group. %d represents a number")
+                value: "Pages: %d",
+                comment: "Label showing how many pages there is in a search group. %d represents a number")
         }
 
         public struct CustomizeHomepage {

diff --git a/Tests/ClientTests/Frontend/Home/HistoryHighlights/HistoryHighlightsViewModelTests.swift b/Tests/ClientTests/Frontend/Home/HistoryHighlights/HistoryHighlightsViewModelTests.swift
@@ -211,7 +211,7 @@ class HistoryHighlightsViewModelTests: XCTestCase {
         XCTAssertNotNil(cell)
         XCTAssertFalse(cell!.isFillerCell)
         XCTAssertEqual(cell!.itemDescription.text,
-                       String.localizedStringWithFormat(.FirefoxHomepage.Common.SitesCount, 2))
+                       String.localizedStringWithFormat(.FirefoxHomepage.Common.PagesCount, 2))
     }
 
     func testDidSelectItem() {