Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

S2 takeover dialog tokens #205

Merged
merged 2 commits into from
Oct 8, 2024
Merged

Conversation

PaliwalSparsh
Copy link
Contributor

Description

Made the following changes to layout and component layout tokens for both mobile and desktop.

New tokens
window-to-edge

takeover-dialog-width
takeover-dialog-height

Motivation and context

Added tokens for the S2 takeover dialog component.

Related issue

https://jira.corp.adobe.com/browse/SDS-13939

Types of changes

  • Patch (bug fixes, typos, mistakes; non-breaking change which fixes an issue)
  • Minor (add a new token, changing a value, deprecating a token; non-breaking change which adds functionality)
  • Major (deleting a token, changing token value type, renaming a token by deprecating the old one; fix or feature that would cause existing functionality to change)
  • Checklist:

  • I have signed the [Adobe Open Source CLA](https://opensource.adobe.com/cla.html).
  • I updated the token in all applicable sets. This applies if updating, adding, or deleting a token that has data across different sets (for example, if the value differs across color themes.)
  • @PaliwalSparsh PaliwalSparsh requested a review from a team as a code owner October 7, 2024 19:50
    @mrcjhicks
    Copy link
    Collaborator

    TESTING spectrum2

    READING spectrum-tokens: /spectrum-tokens/packages/tokens/src/
    READING tokens studio: /spectrum-tokens-studio-data/src/tokens-studio/spectrum2-colors/
    READING tokens studio: /spectrum-tokens-studio-data/src/tokens-studio/spectrum2-non-colors/

    WARNING - studio token uuid collision: (234b3886-77eb-4ad5-9d19-40d801a54617)
    spectrum2/layout.component/desktop,tag-minimum-width-large
    spectrum2/layout.component/desktop,takeover-dialog-width
    spectrum2/layout.component/mobile,takeover-dialog-width
    WARNING - STUDIO MISSING MODE DEFINITION FOR spectrum2/layout.component/tag-minimum-width-large: ["desktop"]

    STUDIO SYNC SUMMARY

    UPDATED METADATA - SPECTRUM UUID: spectrum2/layout.window-to-edge
    UPDATED METADATA - SPECTRUM UUID: spectrum2/layout.component.takeover-dialog-height
    

    SPECTRUM SYNC SUMMARY

    NEW TOKENS: (2) window-to-edge, takeover-dialog-height
    

    TEST COMPLETE

    @mrcjhicks
    Copy link
    Collaborator

    TESTING spectrum2

    READING spectrum-tokens: /spectrum-tokens/packages/tokens/src/
    READING tokens studio: /spectrum-tokens-studio-data/src/tokens-studio/spectrum2-colors/
    READING tokens studio: /spectrum-tokens-studio-data/src/tokens-studio/spectrum2-non-colors/

    STUDIO SYNC SUMMARY

    UPDATED METADATA - SPECTRUM UUID: spectrum2/layout.window-to-edge
    UPDATED METADATA - SPECTRUM UUID: spectrum2/layout.component.takeover-dialog-height
    UPDATED METADATA - SPECTRUM UUID: spectrum2/layout.component.takeover-dialog-width
    

    SPECTRUM SYNC SUMMARY

    NEW TOKENS: (3) window-to-edge, takeover-dialog-height, takeover-dialog-width
    

    TEST COMPLETE

    Copy link
    Contributor

    @lynnhao lynnhao left a comment

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    Looks great!

    @GarthDB GarthDB merged commit 40a251b into main Oct 8, 2024
    4 checks passed
    @GarthDB GarthDB deleted the paliwalsparsh/SDS-13939-takeover-dialog branch October 8, 2024 14:54
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Labels
    None yet
    Projects
    None yet
    Development

    Successfully merging this pull request may close these issues.

    4 participants