fix: Account for viewport position in sprite backend #365
+7
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-merge-queue bot
pushed a commit
to bevyengine/bevy
that referenced
this pull request
Nov 14, 2024
#16386) # Objective - When picking sprites, the pointer is offset from the mouse, causing you to pick sprites you're not mousing over! ## Solution - Shift over the cursor by the minimum of the viewport. ## Testing - I was already using the bevy_mod_picking PR for my project, so it seems to work! - I tested this on the sprite_example (making the camera only render to part of the viewport), and it also works there. ## Notes - This is just aevyrie/bevy_mod_picking#365 but in Bevy form. - We don't need to renormalize the viewport in any way since the viewport is specified in pixels, so all that matters is that the origin is correct. Co-authored-by: johanhelsing <[email protected]>
|
This has been merged into Bevy as bevyengine/bevy#16386 |
mockersf
pushed a commit
to bevyengine/bevy
that referenced
this pull request
Nov 16, 2024
#16386) # Objective - When picking sprites, the pointer is offset from the mouse, causing you to pick sprites you're not mousing over! ## Solution - Shift over the cursor by the minimum of the viewport. ## Testing - I was already using the bevy_mod_picking PR for my project, so it seems to work! - I tested this on the sprite_example (making the camera only render to part of the viewport), and it also works there. ## Notes - This is just aevyrie/bevy_mod_picking#365 but in Bevy form. - We don't need to renormalize the viewport in any way since the viewport is specified in pixels, so all that matters is that the origin is correct. Co-authored-by: johanhelsing <[email protected]>
ecoskey
pushed a commit
to ecoskey/bevy
that referenced
this pull request
Dec 2, 2024
bevyengine#16386) # Objective - When picking sprites, the pointer is offset from the mouse, causing you to pick sprites you're not mousing over! ## Solution - Shift over the cursor by the minimum of the viewport. ## Testing - I was already using the bevy_mod_picking PR for my project, so it seems to work! - I tested this on the sprite_example (making the camera only render to part of the viewport), and it also works there. ## Notes - This is just aevyrie/bevy_mod_picking#365 but in Bevy form. - We don't need to renormalize the viewport in any way since the viewport is specified in pixels, so all that matters is that the origin is correct. Co-authored-by: johanhelsing <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #364