Extend configuration to allow routing based on labels #22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
xinyuluo
commented
May 19, 2020
xinyuluo
commented
- added a new type pr_rule and a new field in config in notabot.atd
- set the default rule to be prefix_rule (for now)
- add print_pr_routing in action.ml
Khady
requested changes
May 19, 2020
src/notabot.atd
Outdated
| prefix : string list; (* empty list means match any *) | ||
| ignore : string list; | ||
| webhook : webhook; | ||
| } | ||
|
|
||
| type pr_rule = { |
There was a problem hiding this comment.
I would call it label_rule instead. As you will probably use this same kind of rule when dealing with issues in addition to pull requests
src/action.ml
Outdated
| @@ -58,3 +58,15 @@ let print_routing rules = | |||
| end; | |||
| Stdio.printf " -> #%s\n%!" rule.webhook.channel; | |||
| end | |||
|
|
|||
| let print_pr_routing rules = | |||
There was a problem hiding this comment.
then this one can be renamed print_label_routing
cyberhuman
reviewed
May 19, 2020
src/notabot.atd
Outdated
| ?gh_webhook_secret: string option; (* if not specified - signatures will not be checked *) | ||
| ?main_branch_name: string option; (* used to filter out notifications about merges of main branch into other branches *) | ||
| } | ||
| } |
There was a problem hiding this comment.
I'm going to restore a proper ocamlformat support, but after this PR is merged
There was a problem hiding this comment.
will do thanks for the tip!
Khady
approved these changes
May 19, 2020
yasunariw
pushed a commit
that referenced
this pull request
Nov 30, 2021
Extend configuration to allow routing based on labels
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.