Feature/#49 - Add an option to hide status cancelled events #51
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Khady
reviewed
Jun 24, 2020
Khady
reviewed
Jun 24, 2020
Khady
reviewed
Jun 24, 2020
|
ok now you have something which works, but only with our current setup. Can you try to make the filtering of configurable? |
ygrek
suggested changes
Jun 24, 2020
AHaliq
changed the title
Khady
reviewed
Jun 25, 2020
Khady
reviewed
Jun 25, 2020
lib/action.ml
Outdated
| let { state; description; _ } = notification in | ||
| match description, state with | ||
| | Some s, Failure | ||
| when Str.string_match (Str.regexp_case_fold "^\\(Build #[0-9]+ canceled by .+\\|Failed (exit status 255)\\)$") s 0 |
There was a problem hiding this comment.
I don't know if it is better to document that we support buildkite only and are open to PR to add other CI systems. Or if we should have a configuration option to let the user write their own regexp.
Khady
requested changes
Jun 26, 2020
Khady
approved these changes
Jun 26, 2020
|
please cleanup commits (e.g. squash into one) |
added end of line regex fix one time check for cancel event added test and fixed regex test: add cache for 78492c2467876259d787538d600cfa0b18a2b814 slack: add culprit sha when notification can't be handled fix call generate for each webhook, defined expected output for new test refactor if to match extract filter logic out of generate_status_notification and into a function in generate_notifications in action.ml removed vscode settings added suprress_cancelle_events config value set supress to true moved function refactor return blank list if filter fail instead of per webhook filter use Re instead of Str compile regexp before usage removed .vscode and move to personal global left new line at end of gitignore removed .vscode refactor to use Option.default, set default to true, added documentation filter merge commit of main branch in status events make test_promote change filter to is, invert bool github actions: update apt packages
|
any reason this is still not merged? |
yasunariw
pushed a commit
that referenced
this pull request
Nov 30, 2021
Feature/#49 - Add an option to hide status cancelled events
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the task
Detect cancel events via status failure and description text and dont emit status when encountered
How to test
References