More A11y work

ahsanghalib · Nov 5, 2020 · dbc0091 · dbc0091
1 parent 1beafd3
commit dbc0091
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 4 deletions.
diff --git a/components/common/Footer/Footer.tsx b/components/common/Footer/Footer.tsx
@@ -84,7 +84,11 @@ const Footer: FC<Props> = ({ className, pages }) => {
           </div>
           <div className="col-span-1 lg:col-span-6 flex items-start lg:justify-end text-primary">
             <div className="flex space-x-6 items-center h-10">
-              <a href="https://github.com/vercel/commerce" className={s.link}>
+              <a
+                aria-label="Github Repository"
+                href="https://github.com/vercel/commerce"
+                className={s.link}
+              >
                 <Github />
               </a>
               <I18nWidget />

diff --git a/components/common/Searchbar/Searchbar.tsx b/components/common/Searchbar/Searchbar.tsx
@@ -22,9 +22,8 @@ const Searchbar: FC<Props> = ({ className, id = 'search' }) => {
         className
       )}
     >
-      <label htmlFor={id}>
+      <label>
         <input
-          id={id}
           className={s.input}
           placeholder="Search for products..."
           defaultValue={router.query.q}

diff --git a/components/common/UserNav/UserNav.tsx b/components/common/UserNav/UserNav.tsx
@@ -34,7 +34,7 @@ const UserNav: FC<Props> = ({ className, children, ...props }) => {
           </li>
           <li className={s.item}>
             <Link href="/wishlist">
-              <a onClick={closeSidebarIfPresent}>
+              <a onClick={closeSidebarIfPresent} aria-label="Wishlist">
                 <Heart />
               </a>
             </Link>