Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add type hints to message_accumulator #1026

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

antonagestam
Copy link

@antonagestam antonagestam commented Jul 2, 2024

Changes

Fixes #

Checklist

  • I think the code is well written
  • Unit tests for the changes exist
  • Documentation reflects the changes
  • Add a new news fragment into the CHANGES folder
    • name it <issue_id>.<type> (e.g. 588.bugfix)
    • if you don't have an issue_id change it to the pr id after creating the PR
    • ensure type is one of the following:
      • .feature: Signifying a new feature.
      • .bugfix: Signifying a bug fix.
      • .doc: Signifying a documentation improvement.
      • .removal: Signifying a deprecation or removal of public API.
      • .misc: A ticket has been closed, but it is not of interest to users.
    • Make sure to use full sentences with correct case and punctuation, for example: Fix issue with non-ascii contents in doctest text files.

@antonagestam antonagestam force-pushed the add-protocol-typing branch from 4a0f6a8 to cd02998 Compare July 2, 2024 22:17
@antonagestam antonagestam force-pushed the add-protocol-typing branch from cd02998 to eea7fa2 Compare July 2, 2024 22:24
@antonagestam antonagestam marked this pull request as ready for review July 2, 2024 22:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant