Use SPDX license identifier #1076
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1076 +/- ##
=======================================
Coverage 95.09% 95.09%
=======================================
Files 114 114
Lines 16981 16981
Branches 1579 1579
=======================================
Hits 16148 16148
Misses 485 485
Partials 348 348
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
| @@ -6,7 +6,7 @@ name = "aiokafka" | |||
| description = "Kafka integration with asyncio" | |||
| readme = "README.rst" | |||
| requires-python = ">=3.9" | |||
| license = { file = "LICENSE" } | |||
| license = { text = "Apache-2.0" } | |||
There was a problem hiding this comment.
According to PEP, this ways is deprecated:
Table values for the
licensekey in the[project]table, including thetextandfiletable subkeys, are now deprecated.
| license = { text = "Apache-2.0" } | |
| license = "Apache-2.0" |
There was a problem hiding this comment.
Yeah. Unfortunately setuptools doesn't support the new syntax yet. Using license.text until then will make updating later a bit easier and also help with readability on PyPI.
before
after
There was a problem hiding this comment.
Probably it's time to switch to hatch (need to figure out how to deal with cython to do this). If not, I'd rather wait until setuptools is fixed.
There was a problem hiding this comment.
If not, I'd rather wait until
setuptoolsis fixed.
This will take some time, probably months. It's currently blocked by other issues which need to be worked out first. pypa/setuptools#4629
I've opened the PR here now, as using the SPDX expression even for the "legacy" License field can help tools which parse the project metadata to look licenses.
Changes
Use the SPDX license identifier as recommended by PEP 639.
https://spdx.org/licenses/Apache-2.0.html