doc(AIP-4114): Add documentation for ECP and new env var default. #1451
Conversation
There was a problem hiding this comment.
Hey hey, happy to review this but someone from the auth team needs to review it as well: https://github.com/orgs/aip-dev/teams/auth
aip/auth/4114.md
Outdated
| 1. Delegates signing operations to keystores, so private keys never leave the security realm. | ||
|
|
||
| Please see [ECP Public Documentation][2] for details on ECP configuration. ECP is | ||
| fully supported in Google Golang libraries and gCloud SDK as of 2023. |
There was a problem hiding this comment.
Are we sure we want to mention which languages/surfaces support it here and not in say the doc site where there are already examples and better means of expressing that? Otherwise we will need to keep this updated whenever a new language/surface supports it.
That said, I'm not opposed to including it if no where else is reasonable - it's good to know and not have to ask around.
There was a problem hiding this comment.
This is a good point - I will omit the last part since the AIP is a recommendation and not a status tracker. Ideally there should be a separate public documentation today on which feature is supported in various clients by language, but no such thing exists AFAIK.
There was a problem hiding this comment.
Yep I agree and TBH the client library AIPs don't have this level of tracking though we regularly ask each other which language supports which feature.
Thanks for the review Noah! Due to several rounds of re-orgs and team shuffling, the auth owners list will need a refresher, I will try to update the list to correctly reflect the new auth owners. |
|
When you're ready for me to review again, hit the re-request button :) |
…ove support status.
No description provided.