Bulk Load CDK: pass file transfer as property instead of env var in tests; kill env var stuff #52056
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
octavia-squidington-iii
added
area/connectors
tryangul
reviewed
Jan 21, 2025
...-cdk/bulk/core/load/src/testFixtures/kotlin/io/airbyte/cdk/load/test/util/IntegrationTest.kt
Outdated
Show resolved
Hide resolved
tryangul
approved these changes
Jan 21, 2025
frifriSF59
reviewed
Jan 21, 2025
...stFixtures/kotlin/io/airbyte/cdk/load/test/util/destination_process/DockerizedDestination.kt
Outdated
Show resolved
Hide resolved
edgao
force-pushed
the
edgao/file_transfer_as_property
branch
2 times, most recently
from
5472e80 to
035f1e6
Compare
edgao
force-pushed
the
edgao/file_transfer_as_property
branch
from
035f1e6 to
f442bc0
Compare
edgao
force-pushed
the
edgao/connectors_opt_into_envs
branch
from
1f0f8d5 to
4b2f153
Compare
edgao
force-pushed
the
edgao/file_transfer_as_property
branch
from
f442bc0 to
a2c9ae6
Compare
edgao
force-pushed
the
edgao/file_transfer_as_property
branch
from
a2c9ae6 to
c96f3e1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
stacked on #51618. Closes https://github.com/airbytehq/airbyte-internal-issues/issues/11305
two commits:
(I'm curious what best practice is for micronaut property/envvar names. We seem to copy paste those everywhere - would it be better to make those constants?)