Bulk Load CDK: final micronaut properties cleanup #52093
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
octavia-squidington-iii
added
area/connectors
tryangul
approved these changes
Jan 22, 2025
edgao
force-pushed
the
edgao/micronaut_constant_shuffling
branch
from
00e5742 to
48d4a65
Compare
postamar
reviewed
Jan 23, 2025
| rate-ms: 900000 # 15 minutes | ||
| window-ms: 900000 # 15 minutes | ||
| destination: | ||
| record-batch-size-override: ${AIRBYTE_DESTINATION_RECORD_BATCH_SIZE_OVERRIDE:null} |
There was a problem hiding this comment.
for future reference: if this file should have existed at all, it should have been in core/load not core/base
There was a problem hiding this comment.
yup, this pr is moving it in there (and also namespacing all the other properties under airbyte.destination.core, which is why git doesn't recognize the file move >.>)
edgao
force-pushed
the
edgao/file_transfer_as_property
branch
from
f442bc0 to
a2c9ae6
Compare
edgao
force-pushed
the
edgao/micronaut_constant_shuffling
branch
from
48d4a65 to
7a05bca
Compare
edgao
force-pushed
the
edgao/file_transfer_as_property
branch
from
a2c9ae6 to
c96f3e1
Compare
edgao
force-pushed
the
edgao/micronaut_constant_shuffling
branch
from
7a05bca to
6cc6cb0
Compare
edgao
force-pushed
the
edgao/file_transfer_as_property
branch
from
c96f3e1 to
57d8302
Compare
edgao
force-pushed
the
edgao/micronaut_constant_shuffling
branch
from
6cc6cb0 to
09099a4
Compare
edgao
merged commit 293e8f3
into
edgao/file_transfer_as_property
26 of 34 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
airbyte.destination.<submodule>.*core/base->core/load