Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

destination-s3: use the non root base image #52103

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

alafanechere
Copy link
Contributor

@alafanechere alafanechere commented Jan 23, 2025

This pull request updates the S3 destination connector to use a new base image and version. It also includes documentation updates to reflect these changes.

Connector updates:

Documentation updates:

Copy link

vercel bot commented Jan 23, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
airbyte-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 23, 2025 10:06am

@octavia-squidington-iii octavia-squidington-iii added area/connectors Connector related issues area/documentation Improvements or additions to documentation connectors/destination/s3 labels Jan 23, 2025
Copy link
Contributor Author

alafanechere commented Jan 23, 2025

@alafanechere alafanechere force-pushed the augustin/01-23-destination-s3_use_the_non_root_base_image branch from c2359b1 to f2a9f3b Compare January 23, 2025 08:16
@alafanechere alafanechere force-pushed the augustin/01-23-airbyte-ci_load_built_image_to_local_docker_host_for_java_connectors branch from ba512d7 to 939f403 Compare January 23, 2025 08:20
@alafanechere alafanechere force-pushed the augustin/01-23-destination-s3_use_the_non_root_base_image branch from f2a9f3b to 435ab09 Compare January 23, 2025 08:20
@alafanechere alafanechere marked this pull request as ready for review January 23, 2025 08:22
@alafanechere alafanechere requested a review from a team as a code owner January 23, 2025 08:22
@alafanechere alafanechere force-pushed the augustin/01-23-airbyte-ci_load_built_image_to_local_docker_host_for_java_connectors branch from 939f403 to 96812da Compare January 23, 2025 08:25
@alafanechere alafanechere requested a review from a team as a code owner January 23, 2025 08:25
@alafanechere alafanechere force-pushed the augustin/01-23-destination-s3_use_the_non_root_base_image branch from 435ab09 to b58ace9 Compare January 23, 2025 08:25
@alafanechere alafanechere force-pushed the augustin/01-23-airbyte-ci_load_built_image_to_local_docker_host_for_java_connectors branch from 96812da to 58c60ca Compare January 23, 2025 08:41
@alafanechere alafanechere force-pushed the augustin/01-23-destination-s3_use_the_non_root_base_image branch from b58ace9 to 6e5a73d Compare January 23, 2025 08:42
@alafanechere alafanechere force-pushed the augustin/01-23-destination-s3_use_the_non_root_base_image branch from 6e5a73d to c195ff6 Compare January 23, 2025 08:49
@alafanechere alafanechere changed the base branch from augustin/01-23-airbyte-ci_load_built_image_to_local_docker_host_for_java_connectors to augustin/01-23-airbyte-ci_stream_gradle_output_to_step_logger January 23, 2025 08:49
@alafanechere alafanechere force-pushed the augustin/01-23-airbyte-ci_stream_gradle_output_to_step_logger branch from c47a276 to 66e6eb9 Compare January 23, 2025 08:50
@alafanechere alafanechere force-pushed the augustin/01-23-destination-s3_use_the_non_root_base_image branch from c195ff6 to c6a998c Compare January 23, 2025 08:50
@alafanechere alafanechere force-pushed the augustin/01-23-airbyte-ci_stream_gradle_output_to_step_logger branch from 66e6eb9 to c83f787 Compare January 23, 2025 09:13
@alafanechere alafanechere force-pushed the augustin/01-23-destination-s3_use_the_non_root_base_image branch from c6a998c to 4992e90 Compare January 23, 2025 09:13
@alafanechere alafanechere force-pushed the augustin/01-23-airbyte-ci_stream_gradle_output_to_step_logger branch from c83f787 to ecb3b81 Compare January 23, 2025 09:54
@alafanechere alafanechere force-pushed the augustin/01-23-destination-s3_use_the_non_root_base_image branch from 4992e90 to 77de031 Compare January 23, 2025 09:54
Base automatically changed from augustin/01-23-airbyte-ci_stream_gradle_output_to_step_logger to master January 23, 2025 09:55
@alafanechere alafanechere force-pushed the augustin/01-23-destination-s3_use_the_non_root_base_image branch from 77de031 to 1c1c309 Compare January 23, 2025 09:56
@edgao
Copy link
Contributor

edgao commented Jan 23, 2025

looks like CI is consistently timing out - we've seen s3 run successfully on other PRs (e.g. #52076), so maybe there's something actually broken?

@natikgadzhi
Copy link
Contributor

@edgao @davinchia with Augustin rotating out soon, it's important to look into this — I doubt Augustin will have enough context to figure out what's going on.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/connectors Connector related issues area/documentation Improvements or additions to documentation connectors/destination/s3
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants