fix(drawer): remove focus guards due to tabIndex a11y issue (uber#4620)

ak06121991 · Nov 15, 2021 · 1fe4178 · 1fe4178
1 parent 53c688c
commit 1fe4178
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 5 deletions.
diff --git a/src/drawer/__tests__/drawer.e2e.js b/src/drawer/__tests__/drawer.e2e.js
@@ -48,10 +48,7 @@ describe('drawer', () => {
     expect(closeButtonIsFocused).toBe(true);
 
     // drawer should be accessible
-    const accessibilityReport = await analyzeAccessibility(page, {
-      // disable tabindex rule because react-focus-lock uses tabindex to trap focus
-      rules: [{id: 'tabindex', enabled: false}],
-    });
+    const accessibilityReport = await analyzeAccessibility(page);
     expect(accessibilityReport).toHaveNoAccessibilityIssues();
 
     // close again

diff --git a/src/drawer/drawer.js b/src/drawer/drawer.js
@@ -253,7 +253,7 @@ class Drawer extends React.Component<DrawerPropsT, DrawerStateT> {
       <LocaleContext.Consumer>
         {locale => {
           return (
-            <FocusLock returnFocus autoFocus={autoFocus}>
+            <FocusLock returnFocus autoFocus={autoFocus} noFocusGuards={true}>
               <Root
                 data-baseweb="drawer"
                 ref={this.getRef('Root')}