Skip to content

Commit

Permalink
Delegate fmpz_poly_mat_transpose to gr_mat, add tests
Browse files Browse the repository at this point in the history
  • Loading branch information
lgoettgens committed Jan 28, 2025
1 parent e049960 commit 5f78f7f
Show file tree
Hide file tree
Showing 3 changed files with 86 additions and 22 deletions.
2 changes: 2 additions & 0 deletions src/fmpz_poly_mat/test/main.c
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,7 @@
#include "t-sqrlow.c"
#include "t-sub.c"
#include "t-trace.c"
#include "t-transpose.c"
#include "t-window_init_clear.c"
#include "t-zero.c"

Expand Down Expand Up @@ -66,6 +67,7 @@ test_struct tests[] =
TEST_FUNCTION(fmpz_poly_mat_sqrlow),
TEST_FUNCTION(fmpz_poly_mat_sub),
TEST_FUNCTION(fmpz_poly_mat_trace),
TEST_FUNCTION(fmpz_poly_mat_transpose),
TEST_FUNCTION(fmpz_poly_mat_window_init_clear),
TEST_FUNCTION(fmpz_poly_mat_zero)
};
Expand Down
79 changes: 79 additions & 0 deletions src/fmpz_poly_mat/test/t-transpose.c
Original file line number Diff line number Diff line change
@@ -0,0 +1,79 @@
/*
Copyright (C) 2025 Lars Göttgens
This file is part of FLINT.
FLINT is free software: you can redistribute it and/or modify it under
the terms of the GNU Lesser General Public License (LGPL) as published
by the Free Software Foundation; either version 3 of the License, or
(at your option) any later version. See <https://www.gnu.org/licenses/>.
*/

#include "test_helpers.h"
#include "fmpz_poly_mat.h"

TEST_FUNCTION_START(fmpz_poly_mat_transpose, state)
{
slong m, n, rep;

/* Rectangular transpose */
for (rep = 0; rep < 100 * flint_test_multiplier(); rep++)
{
fmpz_poly_mat_t A, B, C;

m = n_randint(state, 20);
n = n_randint(state, 20);

fmpz_poly_mat_init(A, m, n);
fmpz_poly_mat_init(B, n, m);
fmpz_poly_mat_init(C, m, n);

fmpz_poly_mat_randtest(A, state, 1 + n_randint(state, 10),
1 + n_randint(state, 100));
fmpz_poly_mat_randtest(B, state, 1 + n_randint(state, 10),
1 + n_randint(state, 100));

fmpz_poly_mat_transpose(B, A);
fmpz_poly_mat_transpose(C, B);

if (!fmpz_poly_mat_equal(C, A))
{
flint_printf("FAIL: C != A\n");
fflush(stdout);
flint_abort();
}

fmpz_poly_mat_clear(A);
fmpz_poly_mat_clear(B);
fmpz_poly_mat_clear(C);
}

/* Self-transpose */
for (rep = 0; rep < 100 * flint_test_multiplier(); rep++)
{
fmpz_poly_mat_t A, B;

m = n_randint(state, 20);

fmpz_poly_mat_init(A, m, m);
fmpz_poly_mat_init(B, m, m);

fmpz_poly_mat_randtest(A, state, 1 + n_randint(state, 10),
1 + n_randint(state, 100));
fmpz_poly_mat_set(B, A);
fmpz_poly_mat_transpose(B, B);
fmpz_poly_mat_transpose(B, B);

if (!fmpz_poly_mat_equal(B, A))
{
flint_printf("FAIL: B != A\n");
fflush(stdout);
flint_abort();
}

fmpz_poly_mat_clear(A);
fmpz_poly_mat_clear(B);
}

TEST_FUNCTION_END(state);
}
27 changes: 5 additions & 22 deletions src/fmpz_poly_mat/transpose.c
Original file line number Diff line number Diff line change
Expand Up @@ -10,31 +10,14 @@
(at your option) any later version. See <https://www.gnu.org/licenses/>.
*/

#include "fmpz_poly.h"
#include "fmpz_poly_mat.h"
#include "gr.h"
#include "gr_mat.h"

void
fmpz_poly_mat_transpose(fmpz_poly_mat_t B, const fmpz_poly_mat_t A)
{
slong i, j;

if (B->r != A->c || B->c != A->r)
{
flint_throw(FLINT_ERROR, "Exception (fmpz_poly_mat_transpose). Incompatible dimensions.\n");
}

if (A == B) /* In-place, guaranteed to be square */
{
for (i = 0; i < A->r - 1; i++)
for (j = i + 1; j < A->c; j++)
fmpz_poly_swap(fmpz_poly_mat_entry(B, i, j),
fmpz_poly_mat_entry(B, j, i));
}
else /* Not aliased; general case */
{
for (i = 0; i < B->r; i++)
for (j = 0; j < B->c; j++)
fmpz_poly_set(fmpz_poly_mat_entry(B, i, j),
fmpz_poly_mat_entry(A, j, i));
}
gr_ctx_t gr_ctx;
gr_ctx_init_fmpz_poly(gr_ctx);
GR_MUST_SUCCEED(gr_mat_transpose((gr_mat_struct *)B, (const gr_mat_struct *) A, gr_ctx));
}

0 comments on commit 5f78f7f

Please sign in to comment.