Respect zero time and print time.Time{}

alecthomas · Sep 25, 2020 · 8eaab51 · 8eaab51
1 parent f2046c2
commit 8eaab51
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 1 deletion.
diff --git a/repr.go b/repr.go
@@ -334,6 +334,11 @@ func isZero(v reflect.Value) bool {
 }
 
 func timeToGo(w io.Writer, t time.Time) {
+	if t.IsZero() {
+		fmt.Fprint(w, "time.Time{}")
+		return
+	}
+
 	var zone string
 	switch loc := t.Location(); loc {
 	case nil:

diff --git a/repr_test.go b/repr_test.go
@@ -144,8 +144,9 @@ func TestReprTime(t *testing.T) {
 		nil,
 		{Date: time.Date(2011, 3, 23, 11, 15, 54, 987654, time.UTC)},
 		{Date: time.Date(2011, 3, 23, 11, 15, 54, 987654, loc)},
+		{Date: time.Time{}},
 	}
-	const want = "[]*repr.timeStruct{&repr.timeStruct{Date: time.Date(2001, 5, 13, 21, 15, 54, 987654, time.FixedZone(\"Repr\", 10800))}, nil, &repr.timeStruct{Date: time.Date(2011, 3, 23, 11, 15, 54, 987654, time.UTC)}, &repr.timeStruct{Date: time.Date(2011, 3, 23, 11, 15, 54, 987654, time.FixedZone(\"AEDT\", 39600))}}"
+	const want = "[]*repr.timeStruct{&repr.timeStruct{Date: time.Date(2001, 5, 13, 21, 15, 54, 987654, time.FixedZone(\"Repr\", 10800))}, nil, &repr.timeStruct{Date: time.Date(2011, 3, 23, 11, 15, 54, 987654, time.UTC)}, &repr.timeStruct{Date: time.Date(2011, 3, 23, 11, 15, 54, 987654, time.FixedZone(\"AEDT\", 39600))}, &repr.timeStruct{Date: time.Time{}}}"
 	s := String(arr)
 	equal(t, want, s)
 
@@ -154,6 +155,7 @@ func TestReprTime(t *testing.T) {
 		nil,
 		{Date: time.Date(2011, 3, 23, 11, 15, 54, 987654, time.UTC)},
 		{Date: time.Date(2011, 3, 23, 11, 15, 54, 987654, time.FixedZone("AEDT", 39600))},
+		{Date: time.Time{}},
 	}
 	s = String(arr)
 	equal(t, want, s)