Better Hammer Bros #403
Better Hammer Bros #403
Conversation
Make them less brutally unfair so much of the time
It was truly stupidly long
Less jank
So they aren't so hard to stomp even after you take damage
I missed another one, can't do anything first try
|
I would encourage the use of more variables (like groundfreezetime). |
|
Global variables in variables.lua is very annoying. It just means you have to do more looking to find them: first you have to check the actual enemy lua to find the variable name or if it's there at all, then go fishing in the sea that is variables.lua |
Consistency is nice |
|
I don't use a good ide, I use notepad and 7zip and it's constantly painful. What even is the point? It's a 1.6 thing and 1.6 is chock full of short-sighted choices. It's not even a case where the variable is used in multiple locations |
|
Using constant variables is just good programming practice to A) help annotate your code / make it more clear what it's doing, and B) so if you decide later you want to change fireball speed or whatever then you can easily do that. You don't have to store them in variables.lua, putting them as locals at the top of hammerbro.lua would be fine as well imo. |
And I think the solution is obvious here |
|
Having them as local variables is fine, it's having them in variables.lua that I find problematic. Variables.lua is cluttered with numbers or other constants that are only used one single time, and serve only to make finding each other more difficult. If you've looked at #583 I give some examples there. It has no benefit over having them near the usage, and only makes finding them take extra steps, even with an IDE. Also I don't think the obvious solution to "the code is hard to read" is the equivalent of "use a magnifying glass" |
|
No one is really questioning whether or not mari0s code is bad and disorganized. If we were starting over sure but it's not worth the time or potential oversights changing it at this point, so might as well try to stay consistent so you at least know the variables will probably be in variables.lua |
Still can't believe how long they were (and technically still are, hurry up Alesan please)
Stars don't make you invincible, Mari0 makes perfect sense
|
There, it uses variables, and also I fixed a bug (which I knew about, but I was too lazy to do before this had any more attention) |
The balls bouncing off walls was horrible, I can't believe I forgot it earlier
|
Bumping this to remind people of the current state of bros in this game
sm16.fire.bros.mp4 |
Why not I suppose. Fixes "return to spawn" behavior eating their initial jump, fixes them attaching to tracks automatically, and just cleans up a smidge
Even slightly nicer-er, I also forgot to mention in the last commit that I fixed map height issues
No description provided.