Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix quicksand #653

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Fix quicksand #653

wants to merge 2 commits into from

Conversation

WilliamFr0g
Copy link
Contributor

Objects currently sink at different speeds in quicksand, sometimes so badly that they will sink upwards. This should fix that

Copy link
Collaborator

@qixils qixils left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This replaces the gravity local variable, which alesan added in 957d534 supposedly to "Fix quicksand speed varying with FPS and gravity", with b.gravity, leaving the gravity local variable unused. An issue with quicksand clearly still remains (prior to this PR) but it feels like the solution should be to fix the gravity local or to remove it entirely if proven not to be necessary. Additionally, does this reintroduce the FPS dependency alesan mentioned and attempted to fix in the prior commit?

@qixils qixils added the bug Something isn't working label Oct 13, 2024
@WilliamFr0g
Copy link
Contributor Author

WilliamFr0g commented Oct 18, 2024

You could probably reimplement the gravity local, it may work better with low gravity that way, but I hadn't considered that at the time. In that case, it should still account for ignoregravity, which it didn't before. The FPS dependency has never been fixed until I did here; Alesan's last commit claimed to fix it but did not.

has anyone ever used quicksand in low gravity anyway
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants