Skip to content

Commit

Permalink
Update text (may to must) and move one message to E:
Browse files Browse the repository at this point in the history
  • Loading branch information
pzb committed Jan 29, 2016
1 parent 9be242f commit 295539e
Show file tree
Hide file tree
Showing 2 changed files with 12 additions and 12 deletions.
22 changes: 11 additions & 11 deletions lib/certlint/cablint.rb
Original file line number Diff line number Diff line change
Expand Up @@ -245,16 +245,16 @@ def self.lint(der)
end
else
if subjattrs.include? 'L'
messages << 'E: BR certificates without organizationName may not include localityName'
messages << 'E: BR certificates without organizationName must not include localityName'
end
if subjattrs.include? 'ST'
messages << 'E: BR certificates without organizationName may not include stateOrProvinceName'
messages << 'E: BR certificates without organizationName must not include stateOrProvinceName'
end
if subjattrs.include? 'street'
messages << 'E: BR certificates without organizationName may not include streetAddress'
messages << 'E: BR certificates without organizationName must not include streetAddress'
end
if subjattrs.include? 'postalCode'
messages << 'E: BR certificates without organizationName may not include postalCode'
messages << 'E: BR certificates without organizationName must not include postalCode'
end
end

Expand Down Expand Up @@ -305,10 +305,10 @@ def self.lint(der)
nameval = nil
case genname.tag
when 0
messages << 'E: BR certificates may not contain otherName type alternative name'
messages << 'E: BR certificates must not contain otherName type alternative name'
next
when 1
messages << 'E: BR certificates may not contain rfc822Name type alternative name'
messages << 'E: BR certificates must not contain rfc822Name type alternative name'
next
when 2
val = genname.value
Expand All @@ -326,16 +326,16 @@ def self.lint(der)
messages += CertLint::IANANames.lint(val).map { |m| m + ' in SAN' }
nameval = val.downcase
when 3
messages << 'E: BR certificates may not contain x400Address type alternative name'
messages << 'E: BR certificates must not contain x400Address type alternative name'
next
when 4
messages << 'E: BR certificates may not contain directoryName type alternative name'
messages << 'E: BR certificates must not contain directoryName type alternative name'
next
when 5
messages << 'E: BR certificates may not contain ediPartyName type alternative name'
messages << 'E: BR certificates must not contain ediPartyName type alternative name'
next
when 6
messages << 'E: BR certificates may not contain uniformResourceIdentifier type alternative name'
messages << 'E: BR certificates must not contain uniformResourceIdentifier type alternative name'
next
when 7
if genname.value.length == 4 || genname.value.length == 16
Expand All @@ -346,7 +346,7 @@ def self.lint(der)
next
end
when 8
messages << 'E: BR certificates may not contain registeredID type alternative name'
messages << 'E: BR certificates must not contain registeredID type alternative name'
next
end
if names.include? nameval
Expand Down
2 changes: 1 addition & 1 deletion lib/certlint/iananames.rb
Original file line number Diff line number Diff line change
Expand Up @@ -87,7 +87,7 @@ def self.lint(fqdn)

# We can't do much with domains that are not fqdns
unless fqdn.include? '.'
messages << 'W: Unqualified domain name'
messages << 'E: Unqualified domain name'
return messages
end

Expand Down

0 comments on commit 295539e

Please sign in to comment.