Skip to content

Commit

Permalink
Merge pull request davestephens#549 from HitLuca/remove-enclosing-str…
Browse files Browse the repository at this point in the history
…ings-for-booleans

 Switched from booleans enclosed in strings to standard booleans
  • Loading branch information
davestephens authored Jul 27, 2022
2 parents 2c86689 + 78899cd commit 16caf4f
Show file tree
Hide file tree
Showing 135 changed files with 152 additions and 165 deletions.
2 changes: 1 addition & 1 deletion docs/applications/gitlab.md
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,6 @@ If Gitea isn't powerful enough for you then consider GitLab. It's a much more po

Set `gitlab_enabled: true` in your `inventories/<your_inventory>/nas.yml` file.

To make GitLab available externally via Traefik set `gitlab_available_externally: "true"` in your `inventories/<your_inventory>/nas.yml` file.
To make GitLab available externally via Traefik set `gitlab_available_externally: true` in your `inventories/<your_inventory>/nas.yml` file.

The first time you run GitLab you'll be prompted for an account's password. The password is for GitLab's `root` administrator account. From there you can log in to create additional users and further configure the application.
2 changes: 1 addition & 1 deletion docs/applications/homeassistant.md
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,6 @@ Open source home automation that puts local control and privacy first. Powered b

Set `homeassistant_enabled: true` in your `inventories/<your_inventory>/nas.yml` file.

If you want to access Home Assistant externally, don't forget to set `homeassistant_available_externally: "true"` in your `inventories/<your_inventory>/nas.yml` file.
If you want to access Home Assistant externally, don't forget to set `homeassistant_available_externally: true` in your `inventories/<your_inventory>/nas.yml` file.

The Home Assistant web interface can be found at <http://ansible_nas_host_or_ip:8123>.
2 changes: 1 addition & 1 deletion docs/applications/joomla.md
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ Joomla! is an award-winning content management system (CMS), which enables you t

Set `joomla_enabled: true` in your `inventories/<your_inventory>/nas.yml` file.

If you want to access Joomla externally, set `joomla_available_externally: "true"` in your `inventories/<your_inventory>/nas.yml` file.
If you want to access Joomla externally, set `joomla_available_externally: true` in your `inventories/<your_inventory>/nas.yml` file.

The Joomla web interface can be found at <http://ansible_nas_host_or_ip:8181>.

Expand Down
2 changes: 1 addition & 1 deletion docs/applications/mylar.md
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,6 @@ An automated Comic Book downloader (cbr/cbz) for use with SABnzbd, NZBGet and to

Set `mylar_enabled: true` in your `inventories/<your_inventory>/nas.yml` file.

If you want to access Mylar externally, don't forget to set `mylar_available_externally: "true"` in your `inventories/<your_inventory>/nas.yml` file.
If you want to access Mylar externally, don't forget to set `mylar_available_externally: true` in your `inventories/<your_inventory>/nas.yml` file.

The Mylar web interface can be found at <http://ansible_nas_host_or_ip:5858>.
2 changes: 1 addition & 1 deletion docs/applications/piwigo.md
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ Piwigo is open source photo gallery software for the web. Designed for organisat

Set `piwigo_enabled: true` in your `inventories/<your_inventory>/nas.yml` file.

If you want to access Piwigo externally, set `piwigo_available_externally: "true"` in your `inventories/<your_inventory>/nas.yml` file.
If you want to access Piwigo externally, set `piwigo_available_externally: true` in your `inventories/<your_inventory>/nas.yml` file.

The Piwigo web interface can be found at <http://ansible_nas_host_or_ip:16923>.

Expand Down
2 changes: 1 addition & 1 deletion docs/applications/speedtest.md
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,6 @@ Continuously track your internet speed

Set `speedtest_enabled: true` in your `inventories/<your_inventory>/nas.yml` file.

If you want to access Speedtest-Tracker externally, don't forget to set `speedtest_available_externally: "true"` in your `inventories/<your_inventory>/nas.yml` file.
If you want to access Speedtest-Tracker externally, don't forget to set `speedtest_available_externally: true` in your `inventories/<your_inventory>/nas.yml` file.

The Speedtest-Tracker interface can be found at <http://ansible_nas_host_or_ip:8765>.
2 changes: 1 addition & 1 deletion docs/applications/tiddlywiki.md
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ TiddlyWiki is a unique non-linear notebook for capturing, organizing, and sharin

Set `tiddlywiki_enabled: true` in your `inventories/<your_inventory>/nas.yml` file.

If you want to access TiddlyWiki externally, set `tiddlywiki_available_externally: "true"` in your `inventories/<your_inventory>/nas.yml` file.
If you want to access TiddlyWiki externally, set `tiddlywiki_available_externally: true` in your `inventories/<your_inventory>/nas.yml` file.

The TiddlyWiki web interface can be found at <http://ansible_nas_host_or_ip:8092>.

Expand Down
2 changes: 1 addition & 1 deletion docs/applications/utorrent.md
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ Docker Container: <https://hub.docker.com/r/ekho/utorrent>

Set `utorrent_enabled: true` in your `inventories/<your_inventory>/nas.yml` file.

If you want to access uTorrent externally, don't forget to set `utorrent_available_externally: "true"` in your `inventories/<your_inventory>/nas.yml` file.
If you want to access uTorrent externally, don't forget to set `utorrent_available_externally: true` in your `inventories/<your_inventory>/nas.yml` file.

The uTorrent web interface can be found at <http://ansible_nas_host_or_ip:8111/gui>:

Expand Down
2 changes: 1 addition & 1 deletion docs/applications/wallabag.md
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ wallabag is a self-hostable PHP application allowing you to not miss any content

Set `wallabag_enabled: true` in your `inventories/<your_inventory>/nas.yml` file.

If you want to access wallabag externally, don't forget to set `wallabag_available_externally: "true"` in your `inventories/<your_inventory>/nas.yml` file.
If you want to access wallabag externally, don't forget to set `wallabag_available_externally: true` in your `inventories/<your_inventory>/nas.yml` file.

I recommend using the mobile app, which will sync with this installation so you have access to your saved articles even if you don't have signal or wifi access.

Expand Down
16 changes: 8 additions & 8 deletions group_vars/all.yml
Original file line number Diff line number Diff line change
Expand Up @@ -236,7 +236,7 @@ samba_netbios_name: "{{ ansible_nas_hostname }}"
### Joomla
###
joomla_data_directory: "{{ docker_home }}/joomla"
joomla_available_externally: "false"
joomla_available_externally: false
joomla_database_password: top_secret
joomla_port: "8181"

Expand All @@ -248,14 +248,14 @@ openvpn_config_directory: "{{ docker_home }}/openvpn"
###
### Guacamole
###
guacamole_available_externally: "false"
guacamole_available_externally: false
guacamole_data_directory: "{{ docker_home }}/guacamole"
guacamole_port: "8090"

###
### Krusader
###
krusader_available_externally: "false"
krusader_available_externally: false
krusader_config_directory: "{{ docker_home }}/krusader/config"
krusader_browse_directory: "/"
krusader_user_id: "0"
Expand All @@ -278,22 +278,22 @@ timemachine_port: "10445"
###
### The Lounge
###
thelounge_available_externally: "false"
thelounge_available_externally: false
thelounge_data_directory: "{{ docker_home }}/thelounge"
thelounge_port_one: "113"
thelounge_port_two: "9002"

###
### Wallabag
###
wallabag_available_externally: "false"
wallabag_available_externally: false
wallabag_data_directory: "{{ docker_home }}/wallabag"
wallabag_port: "7780"

###
### Calibre-web
###
calibre_available_externally: "false"
calibre_available_externally: false
calibre_data_directory: "{{ docker_home }}/calibre"
calibre_user_id: "0"
calibre_group_id: "0"
Expand All @@ -305,7 +305,7 @@ calibre_ebook_conversion: "linuxserver/calibre-web:calibre"
###
### openHAB
###
openhab_available_externally: "false"
openhab_available_externally: false
openhab_docker_image: openhab/openhab:latest
openhab_data_directory: "{{ docker_home }}/openhab"
openhab_port_http: "7777"
Expand All @@ -314,7 +314,7 @@ openhab_port_https: "7778"
###
### Ubooquity
###
ubooquity_available_externally: "false"
ubooquity_available_externally: false
ubooquity_data_directory: "{{ docker_home }}/ubooquity"
ubooquity_user_id: "0"
ubooquity_group_id: "0"
Expand Down
2 changes: 1 addition & 1 deletion roles/airsonic/defaults/main.yml
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
---
airsonic_enabled: false
airsonic_available_externally: "false"
airsonic_available_externally: false

# directories
airsonic_data_directory: "{{ docker_home }}/airsonic"
Expand Down
2 changes: 1 addition & 1 deletion roles/airsonic/tasks/main.yml
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@
restart_policy: unless-stopped
memory: "{{ airsonic_memory }}"
labels:
traefik.enable: "{{ airsonic_available_externally }}"
traefik.enable: "{{ airsonic_available_externally | string }}"
traefik.http.routers.airsonic.rule: "Host(`{{ airsonic_hostname }}.{{ ansible_nas_domain }}`)"
traefik.http.routers.airsonic.tls.certresolver: "letsencrypt"
traefik.http.routers.airsonic.tls.domains[0].main: "{{ ansible_nas_domain }}"
Expand Down
2 changes: 1 addition & 1 deletion roles/bazarr/defaults/main.yml
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
---
bazarr_enabled: false
bazarr_available_externally: "false"
bazarr_available_externally: false

# directories
bazarr_data_directory: "{{ docker_home }}/bazarr/config"
Expand Down
2 changes: 1 addition & 1 deletion roles/bazarr/tasks/main.yml
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@
restart_policy: unless-stopped
memory: "{{ bazarr_memory }}"
labels:
traefik.enable: "{{ bazarr_available_externally }}"
traefik.enable: "{{ bazarr_available_externally | string }}"
traefik.http.routers.bazarr.rule: "Host(`{{ bazarr_hostname }}.{{ ansible_nas_domain }}`)"
traefik.http.routers.bazarr.tls.certresolver: "letsencrypt"
traefik.http.routers.bazarr.tls.domains[0].main: "{{ ansible_nas_domain }}"
Expand Down
2 changes: 1 addition & 1 deletion roles/bitwarden/defaults/main.yml
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
---
bitwarden_enabled: false
bitwarden_available_externally: "false"
bitwarden_available_externally: false
bitwarden_data_directory: "{{ docker_home }}/bitwarden"
bitwarden_port_a: "19080"
bitwarden_port_b: "3012"
Expand Down
4 changes: 2 additions & 2 deletions roles/bitwarden/tasks/main.yml
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
file:
path: "{{ item }}"
state: directory
mode: '0755'
mode: "0755"
with_items:
- "{{ bitwarden_data_directory }}"

Expand All @@ -23,7 +23,7 @@
LOG_FILE: "/data/bitwarden.log"
WEBSOCKET_ENABLED: "true"
labels:
traefik.enable: "{{ bitwarden_available_externally }}"
traefik.enable: "{{ bitwarden_available_externally | string }}"
traefik.http.routers.bitwarden.rule: "Host(`{{ bitwarden_hostname }}.{{ ansible_nas_domain }}`)"
traefik.http.routers.bitwarden.tls.certresolver: "letsencrypt"
traefik.http.routers.bitwarden.tls.domains[0].main: "{{ ansible_nas_domain }}"
Expand Down
2 changes: 1 addition & 1 deletion roles/booksonic/defaults/main.yml
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
---
booksonic_enabled: false
booksonic_available_externally: "false"
booksonic_available_externally: false

# uid / gid
booksonic_user_id: "1000"
Expand Down
2 changes: 1 addition & 1 deletion roles/booksonic/tasks/main.yml
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@
restart_policy: unless-stopped
memory: "{{ booksonic_memory }}"
labels:
traefik.enable: "{{ booksonic_available_externally }}"
traefik.enable: "{{ booksonic_available_externally | string }}"
traefik.http.routers.booksonic.rule: "Host(`{{ booksonic_hostname }}.{{ ansible_nas_domain }}`)"
traefik.http.routers.booksonic.tls.certresolver: "letsencrypt"
traefik.http.routers.booksonic.tls.domains[0].main: "{{ ansible_nas_domain }}"
Expand Down
2 changes: 1 addition & 1 deletion roles/cloudcmd/defaults/main.yml
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
---
# enable or disable the application
cloudcmd_enabled: false
cloudcmd_available_externally: "false"
cloudcmd_available_externally: false

# directories
cloudcmd_data_directory: "{{ docker_home }}/cloudcmd/config"
Expand Down
2 changes: 1 addition & 1 deletion roles/cloudcmd/tasks/main.yml
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@
restart_policy: unless-stopped
memory: "{{ cloudcmd_memory }}"
labels:
traefik.enable: "{{ cloudcmd_available_externally }}"
traefik.enable: "{{ cloudcmd_available_externally | string }}"
traefik.http.routers.cloudcmd.rule: "Host(`{{ cloudcmd_hostname }}.{{ ansible_nas_domain }}`)"
traefik.http.routers.cloudcmd.tls.certresolver: "letsencrypt"
traefik.http.routers.cloudcmd.tls.domains[0].main: "{{ ansible_nas_domain }}"
Expand Down
2 changes: 1 addition & 1 deletion roles/couchpotato/defaults/main.yml
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
---
couchpotato_enabled: false
couchpotato_available_externally: "false"
couchpotato_available_externally: false

# directories
couchpotato_config_directory: "{{ docker_home }}/couchpotato/config"
Expand Down
2 changes: 1 addition & 1 deletion roles/couchpotato/tasks/main.yml
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@
restart_policy: unless-stopped
memory: "{{ couchpotato_memory }}"
labels:
traefik.enable: "{{ couchpotato_available_externally }}"
traefik.enable: "{{ couchpotato_available_externally | string }}"
traefik.http.routers.couchpotato.rule: "Host(`couchpotato.{{ ansible_nas_domain }}`)"
traefik.http.routers.couchpotato.tls.certresolver: "letsencrypt"
traefik.http.routers.couchpotato.tls.domains[0].main: "{{ ansible_nas_domain }}"
Expand Down
2 changes: 1 addition & 1 deletion roles/dashy/defaults/main.yml
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
---
dashy_enabled: false
dashy_available_externally: "false"
dashy_available_externally: false

# network
dashy_port: "8082"
Expand Down
2 changes: 1 addition & 1 deletion roles/dashy/tasks/main.yml
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@
restart_policy: unless-stopped
memory: "{{ dashy_memory }}"
labels:
traefik.enable: "{{ dashy_available_externally }}"
traefik.enable: "{{ dashy_available_externally | string }}"
traefik.http.routers.dashy.rule: "Host(`{{ dashy_hostname }}.{{ ansible_nas_domain }}`)"
traefik.http.routers.dashy.tls.certresolver: "letsencrypt"
traefik.http.routers.dashy.tls.domains[0].main: "{{ ansible_nas_domain }}"
Expand Down
2 changes: 1 addition & 1 deletion roles/deluge/defaults/main.yml
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
---
deluge_enabled: false
deluge_available_externally: "false"
deluge_available_externally: false

# directories
deluge_config_directory: "{{ docker_home }}/deluge/config"
Expand Down
2 changes: 1 addition & 1 deletion roles/deluge/tasks/main.yml
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@
restart_policy: unless-stopped
memory: "{{ deluge_memory }}"
labels:
traefik.enable: "{{ deluge_available_externally }}"
traefik.enable: "{{ deluge_available_externally | string }}"
traefik.http.routers.deluge.rule: "Host(`{{ deluge_hostname }}.{{ ansible_nas_domain }}`)"
traefik.http.routers.deluge.tls.certresolver: "letsencrypt"
traefik.http.routers.deluge.tls.domains[0].main: "{{ ansible_nas_domain }}"
Expand Down
2 changes: 1 addition & 1 deletion roles/dokuwiki/defaults/main.yml
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
---
dokuwiki_enabled: false
dokuwiki_available_externally: "false"
dokuwiki_available_externally: false

# directories
dokuwiki_data_directory: "{{ docker_home }}/dokuwiki"
Expand Down
2 changes: 1 addition & 1 deletion roles/dokuwiki/tasks/main.yml
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@
restart_policy: unless-stopped
memory: "{{ dokuwiki_memory }}"
labels:
traefik.enable: "{{ dokuwiki_available_externally }}"
traefik.enable: "{{ dokuwiki_available_externally | string }}"
traefik.http.routers.dokuwiki.rule: "Host(`{{ dokuwiki_hostname }}.{{ ansible_nas_domain }}`)"
traefik.http.routers.dokuwiki.tls.certresolver: "letsencrypt"
traefik.http.routers.dokuwiki.tls.domains[0].main: "{{ ansible_nas_domain }}"
Expand Down
4 changes: 2 additions & 2 deletions roles/duplicacy/defaults/main.yml
Original file line number Diff line number Diff line change
@@ -1,14 +1,14 @@
---
duplicacy_enabled: false
duplicacy_available_externally: "false"
duplicacy_available_externally: false

# directories
duplicacy_config_directory: "{{ docker_home }}/duplicacy/config"
duplicacy_logs_directory: "{{ docker_home }}/duplicacy/logs"
duplicacy_cache_directory: "{{ docker_home }}/duplicacy/cache"

# permissions
duplicacy_data_permissions: "ro" # Change to 'rw' to allow the UI to restore data
duplicacy_data_permissions: "ro" # Change to 'rw' to allow the UI to restore data

# version
duplicacy_web_version: "Stable"
Expand Down
2 changes: 1 addition & 1 deletion roles/duplicacy/tasks/main.yml
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@
restart_policy: unless-stopped
memory: "{{ duplicacy_memory }}"
labels:
traefik.enable: "{{ duplicacy_available_externally }}"
traefik.enable: "{{ duplicacy_available_externally | string }}"
traefik.http.routers.duplicacy.rule: "Host(`{{ duplicacy_hostname }}.{{ ansible_nas_domain }}`)"
traefik.http.routers.duplicacy.tls.certresolver: "letsencrypt"
traefik.http.routers.duplicacy.tls.domains[0].main: "{{ ansible_nas_domain }}"
Expand Down
2 changes: 1 addition & 1 deletion roles/duplicati/defaults/main.yml
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
---
duplicati_enabled: false
duplicati_available_externally: "false"
duplicati_available_externally: false

# directories
duplicati_data_directory: "{{ docker_home }}/duplicati/config"
Expand Down
2 changes: 1 addition & 1 deletion roles/duplicati/tasks/main.yml
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@
restart_policy: unless-stopped
memory: "{{ duplicati_memory }}"
labels:
traefik.enable: "{{ duplicati_available_externally }}"
traefik.enable: "{{ duplicati_available_externally | string }}"
traefik.http.routers.duplicati.rule: "Host(`{{ duplicati_hostname }}.{{ ansible_nas_domain }}`)"
traefik.http.routers.duplicati.tls.certresolver: "letsencrypt"
traefik.http.routers.duplicati.tls.domains[0].main: "{{ ansible_nas_domain }}"
Expand Down
3 changes: 1 addition & 2 deletions roles/emby/defaults/main.yml
Original file line number Diff line number Diff line change
@@ -1,13 +1,12 @@
---
emby_enabled: false
emby_available_externally: "false"
emby_available_externally: false

# directories
emby_config_directory: "{{ docker_home }}/emby/config"
emby_movies_directory: "{{ movies_root }}"
emby_tv_directory: "{{ tv_root }}"


# If you're paranoid, set permissions to "ro" so Emby won't ever be able to
# delete your files
emby_movies_permissions: "rw"
Expand Down
2 changes: 1 addition & 1 deletion roles/emby/tasks/main.yml
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@
restart_policy: unless-stopped
memory: "{{ emby_memory }}"
labels:
traefik.enable: "{{ emby_available_externally }}"
traefik.enable: "{{ emby_available_externally | string }}"
traefik.http.routers.emby.rule: "Host(`{{ emby_hostname }}.{{ ansible_nas_domain }}`)"
traefik.http.routers.emby.tls.certresolver: "letsencrypt"
traefik.http.routers.emby.tls.domains[0].main: "{{ ansible_nas_domain }}"
Expand Down
2 changes: 1 addition & 1 deletion roles/esphome/defaults/main.yml
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
---
esphome_enabled: false
esphome_available_externally: "false"
esphome_available_externally: false

# directories
esphome_data_directory: "{{ docker_home }}/esphome"
Expand Down
2 changes: 1 addition & 1 deletion roles/esphome/tasks/main.yml
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@
restart_policy: unless-stopped
memory: "{{ esphome_memory }}"
labels:
traefik.enable: "{{ esphome_available_externally }}"
traefik.enable: "{{ esphome_available_externally | string }}"
traefik.http.routers.esphome.rule: "Host(`{{ esphome_hostname }}.{{ ansible_nas_domain }}`)"
traefik.http.routers.esphome.tls.certresolver: "letsencrypt"
traefik.http.routers.esphome.tls.domains[0].main: "{{ ansible_nas_domain }}"
Expand Down
Loading

0 comments on commit 16caf4f

Please sign in to comment.