Fix blade file name convention #24
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
goodjack
reviewed
Apr 11, 2019
README.md
Outdated
| @@ -470,7 +470,7 @@ Variable | camelCase | $articlesWithAuthor | ~~$articles_with_author~~ | |||
| Collection | descriptive, plural | $activeUsers = User::active()->get() | ~~$active, $data~~ | |||
| Object | descriptive, singular | $activeUser = User::active()->first() | ~~$users, $obj~~ | |||
| Config and language files index | snake_case | articles_enabled | ~~ArticlesEnabled; articles-enabled~~ | |||
| View | snake_case | show_filtered.blade.php | ~~showFiltered.blade.php, show-filtered.blade.php~~ | |||
| View | kebab_case | show-filtered.blade.php | ~~showFiltered.blade.php, show_filtered.blade.php~~ | |||
There was a problem hiding this comment.
Should it be kebab-case instead of kebab_case?
There was a problem hiding this comment.
Thanks, fixed
goodjack
approved these changes
Apr 30, 2019
|
Hi guys. I've seen these variations in Laravel projects I'll add a vote. Please use the thumbs up reaction to vote. |
|
viewName.blade.php |
|
view-name.blade.php |
|
view_name.blade.php |
Closed
Daniyal-Javani
force-pushed
the
master
branch
from
2ea7884 to
5706262
Compare
alexeymezenin
added a commit
that referenced
this pull request
Sep 23, 2019
|
Changed to kebab-case according to the vote results. |
gersonkevin23
added a commit
to gersonkevin23/laravel-best-practices
that referenced
this pull request
Mar 3, 2022
sadafrangian3
pushed a commit
to sadafrangian3/best-practices-laravel
that referenced
this pull request
Nov 2, 2022
gregoryross1211
added a commit
to gregoryross1211/Awesmoe-laravel-best-practices
that referenced
this pull request
Nov 11, 2022
sevenstar1124
added a commit
to sevenstar1124/laravel-best-practices
that referenced
this pull request
Feb 8, 2024
happyguy0311
added a commit
to happyguy0311/Laravel_Best_Practise
that referenced
this pull request
May 5, 2024
486xtm
added a commit
to 486xtm/laravel-practice
that referenced
this pull request
May 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think it's better to follow the framework naming convention. In this package they are using kebab-case instead of snake_case for blade files.
https://github.com/illuminate/pagination/tree/master/resources/views