gpio: increase test coverage for button, buzzer, direct pin, led, mot…

…or, and rgb led drivers Signed-off-by: deadprogram <[email protected]>
alexseysua · Mar 21, 2017 · 2d541ca · 2d541ca
1 parent 2314d96
commit 2d541ca
Show file tree

Hide file tree

Showing 6 changed files with 68 additions and 3 deletions.
diff --git a/drivers/gpio/button_driver_test.go b/drivers/gpio/button_driver_test.go
@@ -2,6 +2,7 @@ package gpio
 
 import (
 	"errors"
+	"strings"
 	"testing"
 	"time"
 
@@ -103,3 +104,14 @@ func TestButtonDriverStart(t *testing.T) {
 	}
 
 }
+
+func TestButtonDriverDefaultName(t *testing.T) {
+	g := initTestButtonDriver()
+	gobottest.Assert(t, strings.HasPrefix(g.Name(), "Button"), true)
+}
+
+func TestButtonDriverSetName(t *testing.T) {
+	g := initTestButtonDriver()
+	g.SetName("mybot")
+	gobottest.Assert(t, g.Name(), "mybot")
+}
diff --git a/drivers/gpio/buzzer_driver_test.go b/drivers/gpio/buzzer_driver_test.go
@@ -20,12 +20,17 @@ func initTestBuzzerDriver(conn DigitalWriter) *BuzzerDriver {
 	return NewBuzzerDriver(conn, "1")
 }
 
-func TestBuzzerDriverName(t *testing.T) {
+func TestBuzzerDriverDefaultName(t *testing.T) {
 	g := initTestBuzzerDriver(newGpioTestAdaptor())
-	gobottest.Refute(t, g.Connection(), nil)
 	gobottest.Assert(t, strings.HasPrefix(g.Name(), "Buzzer"), true)
 }
 
+func TestBuzzerDriverSetName(t *testing.T) {
+	g := initTestBuzzerDriver(newGpioTestAdaptor())
+	g.SetName("mybot")
+	gobottest.Assert(t, g.Name(), "mybot")
+}
+
 func TestBuzzerDriverStart(t *testing.T) {
 	d := initTestBuzzerDriver(newGpioTestAdaptor())
 	gobottest.Assert(t, d.Start(), nil)

diff --git a/drivers/gpio/direct_pin_driver_test.go b/drivers/gpio/direct_pin_driver_test.go
@@ -2,6 +2,7 @@ package gpio
 
 import (
 	"errors"
+	"strings"
 	"testing"
 
 	"gobot.io/x/gobot"
@@ -102,10 +103,21 @@ func TestDirectPinDriverPwmWrite(t *testing.T) {
 	gobottest.Assert(t, d.PwmWrite(1), ErrPwmWriteUnsupported)
 }
 
-func TestDirectPinDriverDigitalWrie(t *testing.T) {
+func TestDirectPinDriverServoWrite(t *testing.T) {
 	d := initTestDirectPinDriver(newGpioTestAdaptor())
 	gobottest.Refute(t, d.ServoWrite(1), nil)
 
 	d = initTestDirectPinDriver(&gpioTestBareAdaptor{})
 	gobottest.Assert(t, d.ServoWrite(1), ErrServoWriteUnsupported)
 }
+
+func TestDirectPinDriverDefaultName(t *testing.T) {
+	d := initTestDirectPinDriver(newGpioTestAdaptor())
+	gobottest.Assert(t, strings.HasPrefix(d.Name(), "Direct"), true)
+}
+
+func TestDirectPinDriverSetName(t *testing.T) {
+	d := initTestDirectPinDriver(newGpioTestAdaptor())
+	d.SetName("mybot")
+	gobottest.Assert(t, d.Name(), "mybot")
+}
diff --git a/drivers/gpio/led_driver_test.go b/drivers/gpio/led_driver_test.go
@@ -2,6 +2,7 @@ package gpio
 
 import (
 	"errors"
+	"strings"
 	"testing"
 
 	"gobot.io/x/gobot"
@@ -79,3 +80,14 @@ func TestLedDriverBrightness(t *testing.T) {
 	}
 	gobottest.Assert(t, d.Brightness(150), errors.New("pwm error"))
 }
+
+func TestLEDDriverDefaultName(t *testing.T) {
+	d := initTestLedDriver(&gpioTestDigitalWriter{})
+	gobottest.Assert(t, strings.HasPrefix(d.Name(), "LED"), true)
+}
+
+func TestLEDDriverSetName(t *testing.T) {
+	d := initTestLedDriver(&gpioTestDigitalWriter{})
+	d.SetName("mybot")
+	gobottest.Assert(t, d.Name(), "mybot")
+}
diff --git a/drivers/gpio/motor_driver_test.go b/drivers/gpio/motor_driver_test.go
@@ -1,6 +1,7 @@
 package gpio
 
 import (
+	"strings"
 	"testing"
 
 	"gobot.io/x/gobot"
@@ -110,3 +111,14 @@ func TestMotorDriverDirection(t *testing.T) {
 	d.Direction("forward")
 	d.Direction("backward")
 }
+
+func TestMotorDriverDefaultName(t *testing.T) {
+	d := initTestMotorDriver()
+	gobottest.Assert(t, strings.HasPrefix(d.Name(), "Motor"), true)
+}
+
+func TestMotorDriverSetName(t *testing.T) {
+	d := initTestMotorDriver()
+	d.SetName("mybot")
+	gobottest.Assert(t, d.Name(), "mybot")
+}
diff --git a/drivers/gpio/rgb_led_driver_test.go b/drivers/gpio/rgb_led_driver_test.go
@@ -2,6 +2,7 @@ package gpio
 
 import (
 	"errors"
+	"strings"
 	"testing"
 
 	"gobot.io/x/gobot"
@@ -82,3 +83,14 @@ func TestRgbLedDriverSetLevel(t *testing.T) {
 	}
 	gobottest.Assert(t, d.SetLevel("1", 150), errors.New("pwm error"))
 }
+
+func TestRgbLedDriverDefaultName(t *testing.T) {
+	d := initTestRgbLedDriver(&gpioTestDigitalWriter{})
+	gobottest.Assert(t, strings.HasPrefix(d.Name(), "RGB"), true)
+}
+
+func TestRgbLedDriverSetName(t *testing.T) {
+	d := initTestRgbLedDriver(&gpioTestDigitalWriter{})
+	d.SetName("mybot")
+	gobottest.Assert(t, d.Name(), "mybot")
+}