Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

API: Explicitly set the x-algorand-format for BlockHeaderResponse to 'Bloc… #6247

Merged
merged 2 commits into from
Feb 7, 2025

Conversation

gmalouf
Copy link
Contributor

@gmalouf gmalouf commented Feb 5, 2025

Summary

Explicitly set the x-algorand-format for BlockHeaderResponse to 'BlockHeaderResponse'. This allows for downstream code-generators to differentiate between the slightly different msgpack responses on /v2/blocks/{round} and /v2/blocks/{round}/header

Test Plan

Existing checks should all pass.

Copy link

codecov bot commented Feb 5, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 51.75%. Comparing base (e60d3dd) to head (c1930ee).
Report is 6 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #6247      +/-   ##
==========================================
+ Coverage   49.25%   51.75%   +2.50%     
==========================================
  Files         644      644              
  Lines       86521    86521              
==========================================
+ Hits        42617    44781    +2164     
+ Misses      41040    38872    -2168     
- Partials     2864     2868       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@algorandskiy algorandskiy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Corresponding generator PR: algorand/generator#85

@gmalouf gmalouf marked this pull request as ready for review February 7, 2025 16:25
@gmalouf gmalouf merged commit 121df6f into algorand:master Feb 7, 2025
22 of 23 checks passed
@gmalouf gmalouf deleted the blockheaders-format-tweak branch February 7, 2025 17:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants