RE - Rename partial updates to patch.

alicoding · Jul 13, 2017 · 54f2e13 · 54f2e13
1 parent c9064b2
commit 54f2e13
Show file tree

Hide file tree

Showing 3 changed files with 13 additions and 10 deletions.
diff --git a/src/lib/__tests__/service.integration-test.js b/src/lib/__tests__/service.integration-test.js
@@ -48,13 +48,15 @@ describe('service', () => {
         expect(result).toEqual({ response: 200 });
       });
     });
+  });
 
-    test('should make put request given partial update', () => {
+  describe('#patch', () => {
+    test('should make patch request', () => {
       fetchMock.patch(detailEndpoint, { response: 200 });
 
       const service = buildService(testEndpoint);
 
-      return service.update('1', cake, { partial: true }).then((result) => {
+      return service.patch('1', cake).then((result) => {
         expect(fetchMock.done(detailEndpoint)).toEqual(true);
         expect(result).toEqual({ response: 200 });
       });

diff --git a/src/lib/__tests__/service.test.js b/src/lib/__tests__/service.test.js
@@ -55,13 +55,15 @@ describe('crud-service', () => {
         expect(result).toEqual(cake);
       });
     });
+  });
 
-    test('should make patch request given partial flag set to true', () => {
+  describe('#patch', () => {
+    test('should make patch request', () => {
       api.patch = jest.fn().mockImplementation(mockResponse({ body: cake }));
 
       const service = buildService(TEST_ENDPOINT);
 
-      return service.update('1', cake, { partial: true }).then((result) => {
+      return service.patch('1', cake).then((result) => {
         expect(api.patch).toHaveBeenCalledWith(
           `${TEST_ENDPOINT}/1`,
           cake,

diff --git a/src/lib/service.js b/src/lib/service.js
@@ -28,12 +28,11 @@ class Service {
   create(body) {
     return makeRequest(api.post, this.endpoint, body);
   }
-  update(id, body, { partial } = {}) {
-    return makeRequest(
-      partial ? api.patch : api.put,
-      getUrl(this.endpoint, id),
-      body
-    );
+  update(id, body) {
+    return makeRequest(api.put, getUrl(this.endpoint, id), body);
+  }
+  patch(id, body) {
+    return makeRequest(api.patch, getUrl(this.endpoint, id), body);
   }
   remove(id) {
     return makeRequest(api.delete, getUrl(this.endpoint, id));