Skip to content

Commit

Permalink
ARM: dts: BCM5301X: MR26: MR32: remove bogus nand-ecc-algo property
Browse files Browse the repository at this point in the history
| bcm53015-meraki-mr26.dtb: nand-controller@18028000:
|   nand@0:nand-ecc-algo:0: 'hw' is not one of ['hamming', 'bch', 'rs']
| From schema: Documentation/[...]/nand-controller.yaml
| bcm53016-meraki-mr32.dtb: nand-controller@18028000:
|   nand@0:nand-ecc-algo:0: 'hw' is not one of ['hamming', 'bch', 'rs']
| From schema: Documentation/[...]/nand-controller.yaml

original ECC values for these old Merakis are sadly not
provided by the vendor. It looks like Meraki just stuck
with what Broadcom's SDK was doing... which left this
up to the proprietary nand driver.

Note: The invalid setting was and is handled by brcmnand. It
falls back to "bch" in brcmnand_setup_dev() when ecc.algo is
set to NAND_ECC_ALGO_UNKNOWN (since "hw" is not in the list
above).

A correct nand-ecc-algo = "bch"; is already specified in the
included  "bcm5301x-nand-cs0-bch8.dtsi". So this line can be
dropped.

Reported-by: Rafał Miłecki <[email protected]> (per Mail)
Fixes: 935327a ("ARM: dts: BCM5301X: Add DT for Meraki MR26")
Fixes: ec88a9c ("ARM: BCM5301X: Add DT for Meraki MR32")
Signed-off-by: Christian Lamparter <[email protected]>
Link: https://lore.kernel.org/r/2c4d00dd40124c2ddc0b139cbce7531b108f9052.1686238550.git.chunkeey@gmail.com
Signed-off-by: Florian Fainelli <[email protected]>
  • Loading branch information
chunkeey authored and ffainelli committed Jun 8, 2023
1 parent 7121458 commit a6a1a15
Show file tree
Hide file tree
Showing 2 changed files with 0 additions and 4 deletions.
2 changes: 0 additions & 2 deletions arch/arm/boot/dts/bcm53015-meraki-mr26.dts
Original file line number Diff line number Diff line change
Expand Up @@ -72,8 +72,6 @@
};

&nandcs {
nand-ecc-algo = "hw";

partitions {
compatible = "fixed-partitions";
#address-cells = <0x1>;
Expand Down
2 changes: 0 additions & 2 deletions arch/arm/boot/dts/bcm53016-meraki-mr32.dts
Original file line number Diff line number Diff line change
Expand Up @@ -125,8 +125,6 @@
};

&nandcs {
nand-ecc-algo = "hw";

partitions {
/*
* The partition autodetection does not work for this device.
Expand Down

0 comments on commit a6a1a15

Please sign in to comment.