Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Str 846: Prover Test EvmEE blocks with Schnorr Precompile txn #650

Merged
merged 3 commits into from
Feb 6, 2025

Conversation

MdTeach
Copy link
Contributor

@MdTeach MdTeach commented Feb 3, 2025

Description

  • Adds prover functional test on blocks using Schnorr Precompile txn
  • Refactor existing el schnorr precompile tests

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature/Enhancement (non-breaking change which adds functionality or enhances an existing one)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update
  • Refactor
  • New or updated tests
  • Dependency Update

Notes to Reviewers

  • A quick fix was implemented to prevent precompile contracts from being added to the state trie.
  • This ticket aims to establish a better solution that applies to all stateless precompiles, not just Schnorr.

Checklist

  • I have performed a self-review of my code.
  • I have commented my code where necessary.
  • I have updated the documentation if needed.
  • My changes do not introduce new warnings.
  • I have added tests that prove my changes are effective or that my feature works.
  • New and existing tests pass with my changes.

Related Issues

Copy link

codecov bot commented Feb 3, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 54.68%. Comparing base (4cc7682) to head (36edc57).
Report is 1 commits behind head on main.

@@            Coverage Diff             @@
##             main     #650      +/-   ##
==========================================
+ Coverage   54.66%   54.68%   +0.01%     
==========================================
  Files         314      314              
  Lines       33578    33580       +2     
==========================================
+ Hits        18355    18362       +7     
+ Misses      15223    15218       -5     
Files with missing lines Coverage Δ
crates/proof-impl/evm-ee-stf/src/processor.rs 61.72% <100.00%> (+0.26%) ⬆️

... and 7 files with indirect coverage changes

@MdTeach MdTeach force-pushed the STR-846-prover-test-schnorr branch 2 times, most recently from 370ee1c to 7ef3248 Compare February 3, 2025 19:29
Copy link
Contributor

github-actions bot commented Feb 3, 2025

Commit: 7faa625

SP1 Performance Test Results

program cycles success
BTC_BLOCKSPACE 30,370,673
EL_BLOCK 97,975
CL_BLOCK 91,380
L1_BATCH 30,420,921
L2_BATCH 5,473
CHECKPOINT 28,005

@MdTeach MdTeach force-pushed the STR-846-prover-test-schnorr branch from 7ef3248 to c01d942 Compare February 5, 2025 18:52
@MdTeach MdTeach marked this pull request as ready for review February 5, 2025 20:42
@MdTeach MdTeach requested review from a team as code owners February 5, 2025 20:42
@prajwolrg prajwolrg added this pull request to the merge queue Feb 6, 2025
Merged via the queue into main with commit 2830f20 Feb 6, 2025
18 of 19 checks passed
@prajwolrg prajwolrg deleted the STR-846-prover-test-schnorr branch February 6, 2025 04:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants