Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prover EL: Test non empty block #651

Merged
merged 2 commits into from
Feb 5, 2025
Merged

Prover EL: Test non empty block #651

merged 2 commits into from
Feb 5, 2025

Conversation

MdTeach
Copy link
Contributor

@MdTeach MdTeach commented Feb 3, 2025

Description

  • Updated the prover el block functional test to prove non-empty blocks instead of empty blocks.

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature/Enhancement (non-breaking change which adds functionality or enhances an existing one)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update
  • Refactor
  • New or updated tests
  • Dependency Update

Notes to Reviewers

Checklist

  • I have performed a self-review of my code.
  • I have commented my code where necessary.
  • I have updated the documentation if needed.
  • My changes do not introduce new warnings.
  • I have added tests that prove my changes are effective or that my feature works.
  • New and existing tests pass with my changes.

Related Issues

@MdTeach MdTeach requested a review from a team as a code owner February 3, 2025 20:30
Copy link

codecov bot commented Feb 3, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 54.81%. Comparing base (a0d413d) to head (30ded8d).
Report is 2 commits behind head on main.

@@            Coverage Diff             @@
##             main     #651      +/-   ##
==========================================
- Coverage   54.84%   54.81%   -0.03%     
==========================================
  Files         313      313              
  Lines       33526    33526              
==========================================
- Hits        18386    18376      -10     
- Misses      15140    15150      +10     

see 6 files with indirect coverage changes

Copy link
Contributor

github-actions bot commented Feb 3, 2025

Commit: 96de1c6

SP1 Performance Test Results

program cycles success
BTC_BLOCKSPACE 30,357,713
EL_BLOCK 98,041
CL_BLOCK 58,268
L1_BATCH 30,387,702
L2_BATCH 5,473
CHECKPOINT 15,255

Copy link
Contributor

@delbonis delbonis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor comments on the tests.

functional-tests/utils/eth.py Outdated Show resolved Hide resolved
functional-tests/tests/prover/prover_el_dispatch.py Outdated Show resolved Hide resolved
functional-tests/tests/el_balance_transfer.py Outdated Show resolved Hide resolved
@MdTeach MdTeach force-pushed the prover-el-test-non-empty branch from 64377ad to 30ded8d Compare February 4, 2025 05:23
@MdTeach MdTeach requested a review from delbonis February 4, 2025 05:23
@MdTeach MdTeach enabled auto-merge February 5, 2025 05:57
@MdTeach MdTeach dismissed delbonis’s stale review February 5, 2025 05:57

Changes applied

@MdTeach MdTeach added this pull request to the merge queue Feb 5, 2025
Merged via the queue into main with commit 2554ba8 Feb 5, 2025
19 checks passed
@MdTeach MdTeach deleted the prover-el-test-non-empty branch February 5, 2025 06:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants