Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

STR-453: Rework strata-primitives Buf serialization to get rid of 0x prefix #652

Merged
merged 4 commits into from
Feb 4, 2025

Conversation

evgenyzdanovich
Copy link
Contributor

Description

  • remove 0x prefix from strata-primitives Buf serialization,
  • remove revm-primitives and reth-primitives from deps list of strata-primitives,
  • adjust fntests.

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature/Enhancement (non-breaking change which adds functionality or enhances an existing one)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update
  • Refactor
  • New or updated tests
  • Dependency Update

Notes to Reviewers

Checklist

  • I have performed a self-review of my code.
  • I have commented my code where necessary.
  • I have updated the documentation if needed.
  • My changes do not introduce new warnings.
  • I have added tests that prove my changes are effective or that my feature works.
  • New and existing tests pass with my changes.

Related Issues

@evgenyzdanovich evgenyzdanovich requested review from a team as code owners February 3, 2025 23:36
@evgenyzdanovich
Copy link
Contributor Author

evgenyzdanovich commented Feb 3, 2025

@delbonis
Got rid of reth-primitives and revm-primitives to simplify deps list of strata-primitives.
Tbh, I got somewhat controversial feelings about that, the usage of Buf became little less nice where a conversion to FixedBytes is needed. Would be glad to hear back your opinion.

Please take a look.

delbonis
delbonis previously approved these changes Feb 3, 2025
Copy link
Contributor

@delbonis delbonis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fantastic! Thank you!

Copy link

codecov bot commented Feb 4, 2025

Codecov Report

Attention: Patch coverage is 75.69444% with 35 lines in your changes missing coverage. Please review.

Project coverage is 54.85%. Comparing base (a0d413d) to head (0846553).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
crates/primitives/src/macros.rs 75.00% 30 Missing ⚠️
crates/evmexec/src/fork_choice_state.rs 0.00% 3 Missing ⚠️
bin/prover-client/src/operators/cl_stf.rs 0.00% 1 Missing ⚠️
bin/prover-client/src/operators/evm_ee.rs 0.00% 1 Missing ⚠️
@@            Coverage Diff             @@
##             main     #652      +/-   ##
==========================================
+ Coverage   54.84%   54.85%   +0.01%     
==========================================
  Files         313      313              
  Lines       33526    33639     +113     
==========================================
+ Hits        18386    18452      +66     
- Misses      15140    15187      +47     
Files with missing lines Coverage Δ
crates/evmexec/src/block.rs 100.00% <100.00%> (ø)
crates/evmexec/src/engine.rs 66.16% <100.00%> (ø)
crates/primitives/src/buf.rs 90.51% <100.00%> (+1.09%) ⬆️
crates/primitives/src/l1/btc.rs 82.56% <100.00%> (-0.05%) ⬇️
crates/proof-impl/evm-ee-stf/src/utils.rs 67.44% <100.00%> (ø)
bin/prover-client/src/operators/cl_stf.rs 0.00% <0.00%> (ø)
bin/prover-client/src/operators/evm_ee.rs 0.00% <0.00%> (ø)
crates/evmexec/src/fork_choice_state.rs 0.00% <0.00%> (ø)
crates/primitives/src/macros.rs 79.73% <75.00%> (-7.67%) ⬇️

... and 6 files with indirect coverage changes

Copy link
Contributor

github-actions bot commented Feb 4, 2025

Commit: b2acd2a

SP1 Performance Test Results

program cycles success
BTC_BLOCKSPACE 30,370,673
EL_BLOCK 97,975
CL_BLOCK 91,310
L1_BATCH 30,420,921
L2_BATCH 5,473
CHECKPOINT 28,005

@delbonis
Copy link
Contributor

delbonis commented Feb 4, 2025

Force merging to keep things moving.

@delbonis delbonis merged commit 8ec94e7 into main Feb 4, 2025
19 checks passed
@delbonis delbonis deleted the str-453-buf-ser branch February 4, 2025 22:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants