Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sp1 guests enable feature zkvm-verify #670

Merged
merged 1 commit into from
Feb 13, 2025
Merged

Conversation

MdTeach
Copy link
Contributor

@MdTeach MdTeach commented Feb 13, 2025

Description

After the zkaleido update to v0.1.0-alpha-rc2 it seems building elf in none-mock mode.

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature/Enhancement (non-breaking change which adds functionality or enhances an existing one)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update
  • Refactor
  • New or updated tests
  • Dependency Update

Notes to Reviewers

Checklist

  • I have performed a self-review of my code.
  • I have commented my code where necessary.
  • I have updated the documentation if needed.
  • My changes do not introduce new warnings.
  • I have added (where necessary) tests that prove my changes are effective or that my feature works.
  • New and existing tests pass with my changes.

Related Issues

@MdTeach MdTeach requested review from a team as code owners February 13, 2025 10:53
Copy link

codecov bot commented Feb 13, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 54.66%. Comparing base (32595ac) to head (8d1c894).
Report is 1 commits behind head on main.

@@            Coverage Diff             @@
##             main     #670      +/-   ##
==========================================
- Coverage   54.69%   54.66%   -0.04%     
==========================================
  Files         318      318              
  Lines       34048    34048              
==========================================
- Hits        18624    18613      -11     
- Misses      15424    15435      +11     

see 7 files with indirect coverage changes

Copy link
Contributor

Commit: 06af279

SP1 Performance Test Results

program cycles success
BTC_BLOCKSPACE 30,370,506
EL_BLOCK 97,791
CL_BLOCK 89,672
L1_BATCH 30,419,728
L2_BATCH 3,432
CHECKPOINT 25,784

Copy link
Member

@storopoli storopoli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 8d1c894.
We should implement a CI check somewhere that detects
"elf in none-mock mode".

@MdTeach MdTeach added this pull request to the merge queue Feb 13, 2025
Merged via the queue into main with commit 42592a9 Feb 13, 2025
19 checks passed
@MdTeach MdTeach deleted the STR-1032-update-zkaleido-rc2-2 branch February 13, 2025 16:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants