create validation to stop admins from being locked out of their account #1848
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
koetsier
force-pushed
the
GW-624-Prevent-admins-from-removing-another-admin-if-it-leaves-only-1-admin
branch
from
15ecb34
to
d3b7e0c
Compare
iram-shehzadi
force-pushed
the
GW-624-Prevent-admins-from-removing-another-admin-if-it-leaves-only-1-admin
branch
from
d3b7e0c
to
731cb37
Compare
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
iram-shehzadi
force-pushed
the
GW-624-Prevent-admins-from-removing-another-admin-if-it-leaves-only-1-admin
branch
from
6159313
to
86845ab
Compare
koetsier
reviewed
Jun 19, 2023
| <p class="govuk-body govuk-!-margin-bottom-4"> <%= @membership.user.email %> </p> | ||
|
|
||
| <%= render "memberships/minimum_two_administrators_required" %> | ||
|
|
There was a problem hiding this comment.
Maybe confirm could be called something more descriptive to distinguish it from confirming removing a user?
iram-shehzadi
force-pushed
the
GW-624-Prevent-admins-from-removing-another-admin-if-it-leaves-only-1-admin
branch
from
ce387bb
to
b6eb3c5
Compare
koetsier
force-pushed
the
GW-624-Prevent-admins-from-removing-another-admin-if-it-leaves-only-1-admin
branch
from
b6eb3c5
to
810cb0f
Compare
…min for the organisation changes made after review missed an end changes
iram-shehzadi
force-pushed
the
GW-624-Prevent-admins-from-removing-another-admin-if-it-leaves-only-1-admin
branch
from
810cb0f
to
324837d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Introduce enhancements to the administrator management process. The changes include allowing modifications to administrators only if there are two or more administrators present within an organisation. It also incorporates the addition of confirmations, reminders, and error summaries to provide a more secure and reliable experience.
Why
The objective of these enhancements is to address the following goals:
Security: By requiring a minimum of two administrators, we ensure that organisations are not left without an admin in case of any unforeseen circumstances, such as one admin leaving or getting locked out of their account.
Reliability: By incorporating confirmations, reminders, and error summaries, we improve the user experience and help administrators make informed decisions while managing the administrator accounts. This reduces the risk of errors and improves the overall reliability of the system.
By implementing these improvements, we aim to create a more robust and user-friendly environment for administrators and organisations. The changes will enhance the overall security posture and operational continuity, reducing the likelihood of account lockouts and ensuring organisations have appropriate contacts for support.
Link to Jira card (if applicable):
https://technologyprogramme.atlassian.net/browse/GW-624