Skip to content

Commit

Permalink
Do not set parent keymap of magit-todos-section-map
Browse files Browse the repository at this point in the history
This is not necessary to make the regular magit-status keys work in
the TODOs section.

In fact, it causes a bug when used with evil-collection, which uses x
instead of k for delete (so that k can move the cursor up one line).
Setting the parent keymap unnecessarily confuses evil-collection and
causes k to attempt to delete the "thing" at point instead of
scrolling up.
  • Loading branch information
bcc32 authored and alphapapa committed Mar 21, 2024
1 parent dfcd8d6 commit 7185bca
Showing 1 changed file with 0 additions and 1 deletion.
1 change: 0 additions & 1 deletion magit-todos.el
Original file line number Diff line number Diff line change
Expand Up @@ -119,7 +119,6 @@ Used to avoid running multiple simultaneous scans for a

(defvar magit-todos-section-map
(let ((map (make-sparse-keymap)))
(set-keymap-parent map magit-status-mode-map)
(define-key map "b" #'magit-todos-branch-list-toggle)
(define-key map "B" #'magit-todos-branch-list-set-commit)
(define-key map [remap magit-visit-thing] #'magit-todos-list)
Expand Down

0 comments on commit 7185bca

Please sign in to comment.