plugin-procfs automatically increases file descriptors soft limit #118
+24
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ahuret
force-pushed
the
auto-increase-file-descriptors-soft-limit
branch
from
fb711e3 to
28ed047
Compare
|
Closes #65 |
AngeCyp
reviewed
Feb 25, 2025
TheElectronWill
requested changes
Mar 3, 2025
ahuret
force-pushed
the
auto-increase-file-descriptors-soft-limit
branch
from
28ed047 to
b480e39
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Automatically increase alumet process's file descriptors soft limit when plugin-procfs starts in order to prevent 'Too many open files' error that happened because procfs plugin opens lot of files.
It starts without condition (we could, later, add a configuration option - plugin side - to disable this behavior in some scenarios where administrator would like to manage this limit precisely).
The current implementation will check for the process hard limit and will update soft limit to reach the hard limit. This way the user has still control on the overall process limit - by defining the hard limit.
A future implementation could also be located in Alumet's core to perform the same operation for all the plugins.